Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Features for Cremona databases #24718

Closed
jdemeyer opened this issue Feb 12, 2018 · 13 comments
Closed

Use Features for Cremona databases #24718

jdemeyer opened this issue Feb 12, 2018 · 13 comments

Comments

@jdemeyer
Copy link

Split off from #20382.

We should also use the database location discovered by the feature check instead of hardcoding it.

Depends on #20382

CC: @saraedum @kiwifb @antonio-rojas

Component: misc

Author: Julian Rüth

Branch/Commit: u/jdemeyer/use_features_for_cremona_databases @ 628f35e

Reviewer: Julian Rüth

Issue created by migration from https://trac.sagemath.org/ticket/24718

@jdemeyer jdemeyer added this to the sage-8.2 milestone Feb 12, 2018
@saraedum
Copy link
Member

comment:1

Why would you split that off if we already had a positive review anyway?

@jdemeyer
Copy link
Author

@saraedum
Copy link
Member

Changed branch from u/jdemeyer/use_features_for_cremona_databases to none

@saraedum
Copy link
Member

comment:3

Hm…probably I remember incorrectly and there was no positive review yet ;)

@saraedum
Copy link
Member

Commit: 628f35e

@saraedum
Copy link
Member

@saraedum
Copy link
Member

New commits:

628f35eAdd Features to check the environment at runtime

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

comment:8

There is a simpler patch at #25825.

@saraedum
Copy link
Member

comment:9

So, should this be closed in favor of #25825?

@jdemeyer
Copy link
Author

comment:10

I'll leave that decision to you, I don't know the purpose of your other changes here.

@saraedum
Copy link
Member

Reviewer: Julian Rüth

@saraedum saraedum removed this from the sage-8.2 milestone Jul 12, 2018
@embray
Copy link
Contributor

embray commented Feb 26, 2019

comment:13

Presuming these are all correctly reviewed as either duplicate, invalid, or wontfix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants