New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Features for Cremona databases #24718
Comments
comment:1
Why would you split that off if we already had a positive review anyway? |
Changed branch from u/jdemeyer/use_features_for_cremona_databases to none |
comment:3
Hm…probably I remember incorrectly and there was no positive review yet ;) |
Commit: |
New commits:
|
This comment has been minimized.
This comment has been minimized.
comment:8
There is a simpler patch at #25825. |
comment:9
So, should this be closed in favor of #25825? |
comment:10
I'll leave that decision to you, I don't know the purpose of your other changes here. |
Reviewer: Julian Rüth |
comment:13
Presuming these are all correctly reviewed as either duplicate, invalid, or wontfix. |
Split off from #20382.
We should also use the database location discovered by the feature check instead of hardcoding it.
Depends on #20382
CC: @saraedum @kiwifb @antonio-rojas
Component: misc
Author: Julian Rüth
Branch/Commit: u/jdemeyer/use_features_for_cremona_databases @
628f35e
Reviewer: Julian Rüth
Issue created by migration from https://trac.sagemath.org/ticket/24718
The text was updated successfully, but these errors were encountered: