Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open lazy_import cache file in binary mode #24739

Closed
jdemeyer opened this issue Feb 15, 2018 · 6 comments
Closed

Open lazy_import cache file in binary mode #24739

jdemeyer opened this issue Feb 15, 2018 · 6 comments
Labels
c: python3 p: major / 3 t: bug
Milestone
sage-8.2

Comments

@jdemeyer
Copy link

CC: @fchapoton @embray

Component: python3

Author: Jeroen Demeyer

Branch/Commit: 154e111

Reviewer: Erik Bray

Issue created by migration from https://trac.sagemath.org/ticket/24739
@jdemeyer jdemeyer added this to the sage-8.2 milestone Feb 15, 2018
@jdemeyer
Copy link
Author

Branch: u/jdemeyer/open_lazy_import_cache_file_in_binary_mode

@jdemeyer
Copy link
Author

New commits:

154e111Open lazy_import cache file in binary mode

@jdemeyer
Copy link
Author

Commit: 154e111

@embray
Copy link
Contributor

embray commented Feb 15, 2018

comment:3

In fact I already have this same change in my Python 3 branch.

@embray
Copy link
Contributor

embray commented Feb 15, 2018

Reviewer: Erik Bray

@vbraun
Copy link
Member

vbraun commented Feb 18, 2018

Changed branch from u/jdemeyer/open_lazy_import_cache_file_in_binary_mode to 154e111

@vbraun vbraun closed this as completed in 4c905b7 Feb 18, 2018
@embray embray mentioned this issue Feb 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: bug
Projects
None yet
Milestone
sage-8.2
Development

No branches or pull requests
3 participants
@embray @vbraun @jdemeyer