Don't run pcre test suite on Cygwin

[embray]

See #24628 comment:10

Component: porting: Cygwin

Author: Erik Bray

Branch/Commit: e4e85e8

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/24756

[embray]

Commit: 1689baa

[embray]

Branch: u/embray/cygwin/pcre/check

[embray]

Author: Erik Bray

[embray]

New commits:

1689baa

Fixes https://github.com/sagemath/sage/issues/24756

[jdemeyer]

comment:2

Just a question: do you build R on Cygwin? I ask because R needs PCRE and a broken PCRE might yield a broken R. This is how we found out about the PCRE issues on Solaris.

Or maybe only specific parts of PCRE are broken that are not used by R on Cygwin.

[embray]

comment:4

I don't know--there's like one test for PCRE that fails but I haven't looked into it. The full tests for R have never passed on Cygwin either; see #22866. But I'll run them again to see if any of them are "obviously" regexp related (I'd be surprised).

I'd certainly like to address #22866 but it's low priority short of actual bug reports from users (and I don't think many people are installing Sage in order to use R on Windows...)

[jdemeyer]

comment:5

Replying to @embray:

I don't know--there's like one test for PCRE that fails but I haven't looked into it. The full tests for R have never passed on Cygwin either

On Solaris, even the build of R fails with the broken PCRE. So it seems that the Cygwin problem is not that severe.

The only thing that I'm missing in this branch is a comment saying that we don't run the testsuite on Cygwin because it fails always in a way which doesn't seem to affect other packages. positive review if you add that.

[jdemeyer]

Reviewer: Jeroen Demeyer

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

e4e85e8

Comment

[sagetrac-git]

Changed commit from 1689baa to e4e85e8

[embray]

comment:8

I think the additional comment is mostly superfluous since there's already a link to the original ticket, which could also be updated with a note about this. But I don't object.

---

New commits:

e4e85e8

Comment

[vbraun]

Changed branch from u/embray/cygwin/pcre/check to e4e85e8