New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort the repr of PolyDict by its dict keys #24759
Comments
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Reviewer: Jeroen Demeyer |
comment:3
Interesting. I never heard about positive review if tests pass. |
comment:4
Failing tests in |
Changed branch from u/embray/polydict-sort-repr to public/polydict-sort-repr |
New commits:
|
Changed reviewer from Jeroen Demeyer to Jeroen Demeyer, Frédéric Chapoton |
comment:6
green bot. I am setting to positive. |
comment:7
Merge conflict |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:10
Huh, thanks for fixing those additional tests. Those must be new since I first made this change (which was actually quite a few weeks ago now). |
Changed branch from public/polydict-sort-repr to |
This is one of those cases where a class has a
dict
representation embedded in its repr, so where IPython would normally pprint the plaindict
it does not pprint the embeddeddict
.The
PolyDict
class is only used internally so this should be a low impact change, but that enhances its testability (especially in moving to Python 3).Component: misc
Author: Erik Bray
Branch/Commit:
f2ea845
Reviewer: Jeroen Demeyer, Frédéric Chapoton
Issue created by migration from https://trac.sagemath.org/ticket/24759
The text was updated successfully, but these errors were encountered: