add parameter solver to method chromatic_number

[dcoudert]

When algorithm='MILP', we must be able to select the LP solver. This is not the case yet.

CC: @jm58660

Component: graph theory

Author: David Coudert

Branch/Commit: 9266636

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/24782

[dcoudert]

Branch: public/24782_chromatic_number

[dcoudert]

comment:1

No need to add specific extra tests since the solver parameter is tested in method vertex_coloring.

---

New commits:

820526d

trac #24782: add parameter solver to chromatic_number

[dcoudert]

Commit: 820526d

[sagetrac-git]

Changed commit from 820526d to 626660e

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

626660e

trac #24782: Merged with 8.2.beta8

[tscrim]

comment:3

Nitpick, but you can just use

-:meth:`solve <sage.numerical.mip.MixedIntegerLinearProgram.solve>`
+:meth:`~sage.numerical.mip.MixedIntegerLinearProgram.solve`
-:class:`MixedIntegerLinearProgram <sage.numerical.mip.MixedIntegerLinearProgram>`
+:class:`~sage.numerical.mip.MixedIntegerLinearProgram`

Otherwise LGTM. You can set a positive review once fixed or if you want to just ignore.

[tscrim]

Reviewer: Travis Scrimshaw

[jm58660]

comment:4

A sidenote: Should we test for a combination of solver != None and algorithm != 'MILP'? At least it is not important, so don't bother with it on this ticket.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

dcab836

trac #24782: improve links in documentation

[sagetrac-git]

Changed commit from 626660e to dcab836

[dcoudert]

comment:6

I changed the links. However, I don't want to test the combination algorithm / solver. It's not done elsewhere (in general) and we can ignore the solver if we use another algorithm.

[sagetrac-git]

Changed commit from dcab836 to 9266636

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

9266636

trac #24782: Merged with 8.3.beta0

[tscrim]

comment:9

Sorry, forgot about this. LGTM.

[vbraun]

Changed branch from public/24782_chromatic_number to 9266636