Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3: updates to sage.interfaces.qsieve #24789

Closed
embray opened this issue Feb 20, 2018 · 4 comments
Closed

py3: updates to sage.interfaces.qsieve #24789

embray opened this issue Feb 20, 2018 · 4 comments

Comments

@embray
Copy link
Contributor

embray commented Feb 20, 2018

This has a few small changes, most of which were difficult to separate from each other:

  • Use subprocess.Popen instead of os.popen
  • Don't set os.environ['TMPDIR'] globally--by using subprocess.Popen we
    can update the environment just for the subprocess
  • str/bytes fixes for Python 3

Previously this was also reusing the same tmpdir for all qsieve calls, but there does not appear to be any actual reason to do that since it appears to clean up all the files in its temp dir between runs anyways.

Component: python3

Keywords: flintqs

Author: Erik Bray

Branch/Commit: 400eabc

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/24789

@embray embray added this to the sage-8.2 milestone Feb 20, 2018
@jdemeyer
Copy link

comment:2

Makes sense. positive review if tests pass.

@jdemeyer
Copy link

Reviewer: Jeroen Demeyer

@fchapoton
Copy link
Contributor

comment:4

ok

@vbraun
Copy link
Member

vbraun commented Feb 22, 2018

Changed branch from u/embray/python3/sage-interfaces-qsieve to 400eabc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants