Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing some bad use of raise #24803

Closed
fchapoton opened this issue Feb 21, 2018 · 7 comments
Closed

fixing some bad use of raise #24803

fchapoton opened this issue Feb 21, 2018 · 7 comments
Labels
c: geometry p: major / 3 t: enhancement
Milestone
sage-8.2

Comments

@fchapoton
Copy link
Contributor

Component: geometry

Author: Frédéric Chapoton

Branch/Commit: f0ac547

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/24803
@fchapoton fchapoton added this to the sage-8.2 milestone Feb 21, 2018
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/24803

@fchapoton
Copy link
Contributor Author

Commit: f0ac547

@fchapoton
Copy link
Contributor Author

New commits:

f0ac547fixing bad use of raise

@tscrim
Copy link
Collaborator

tscrim commented Feb 21, 2018

comment:2

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Feb 21, 2018

Reviewer: Travis Scrimshaw

@fchapoton
Copy link
Contributor Author

comment:3

Thanks

@fchapoton fchapoton changed the title fixing some bas use of raise fixing some bad use of raise Feb 21, 2018
@vbraun
Copy link
Member

vbraun commented Feb 22, 2018

Changed branch from u/chapoton/24803 to f0ac547

@vbraun vbraun closed this as completed in deaa572 Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.2
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton