Issue with p-adic printing #24843

xcaruso · 2018-02-26T14:54:52Z

sage: R = Zp(2, print_mode='digits', show_prec=True)
sage: R(0,10)
...0000000000^10)

Depends on #23450
Depends on #23218

CC: @roed314 @saraedum

Component: padics

Keywords: printing padics, padicIMA

Author: Xavier Caruso

Branch/Commit: a736db8

Reviewer: David Roe

Issue created by migration from https://trac.sagemath.org/ticket/24843

The text was updated successfully, but these errors were encountered:

xcaruso · 2018-02-28T13:35:34Z

Branch: u/caruso/padic_printing

xcaruso · 2018-02-28T13:43:27Z

Commit: 5bf6d9d

xcaruso · 2018-02-28T13:43:27Z

Author: Xavier Caruso

xcaruso · 2018-02-28T13:43:27Z

comment:2

I fixed this issue and addressed at the same time #23234.

I've extended the set of possible values allowed for the keyword show_prec: it can now either none (no precision is printed), bigoh or dots. A boolean is still possible: False always means none while True means bigoh or dots depending on the printing mode.

New commits:

`5bf6d9d`	`New options for show_prec: 'none', 'bigoh' and 'dots'`

roed314 · 2018-02-28T14:44:58Z

Changed branch from u/caruso/padic_printing to u/roed/padic_printing

roed314 · 2018-02-28T14:45:59Z

Changed commit from 5bf6d9d to eb99ef3

roed314 · 2018-02-28T14:45:59Z

Reviewer: David Roe

roed314 · 2018-02-28T14:45:59Z

comment:4

If Xavier is happy with my changes, positive review.

New commits:

`eb99ef3`	`Fix some more doctest output, a few minor changes and comments`

xcaruso · 2018-02-28T19:24:45Z

comment:5

I am (as soon as the patchbot does not complain).

sagetrac-git · 2018-02-28T20:18:09Z

Changed commit from eb99ef3 to c6c0cd8

sagetrac-git · 2018-02-28T20:18:09Z

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

`8b239f4`	`trac 23450 details of doc`
`93d4e32`	`Merge branch 'public/23450' in 8.1`
`14f591c`	`fixing 2 doctests`
`cf85a34`	`Merge branch 'public/23450' of ssh://trac.sagemath.org/sage into t/23450/padic_smith`
`7ad838a`	`Remove _get_matrix_class that was inadvertently added in a merge`
`b5863a1`	`Add newline back in from fix to matrix_space.py`
`777f494`	`Remove the tracks_precision method and update the p-adic smith form to be able to deal with lattice elements`
`d78a1d5`	`Add exact parameter to _matrix_smith_form, fix precision behavior and allow integral=True for non-padic matrices`
`d9ad1e5`	`Merge branch 't/23450/padic_smith' into t/24843/padic_printing`
`c6c0cd8`	`Fix doctest in matrix2 due to changes in printing`

roed314 · 2018-02-28T20:19:35Z

Dependencies: #23450

sagetrac-git · 2018-02-28T20:39:04Z

Changed commit from c6c0cd8 to ba0ea8c

sagetrac-git · 2018-02-28T20:39:04Z

Branch pushed to git repo; I updated commit sha1. New commits:

`ba0ea8c`	`Fix doctest in Explicit Methods in Number Theory`

roed314 · 2018-07-22T20:07:13Z

Changed keywords from printing padics to printing padics, padicIMA

sagetrac-git · 2018-07-23T15:49:12Z

Changed commit from ba0ea8c to debf1fc

sagetrac-git · 2018-07-23T15:49:12Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`debf1fc`	`Commit to make different from develop`

roed314 · 2018-07-25T00:11:54Z

Changed branch from u/roed/padic_printing to u/roed/padic_prints

sagetrac-git · 2018-07-25T00:22:23Z

Branch pushed to git repo; I updated commit sha1. New commits:

`c3af1bd`	`Merge branch 'u/roed/padic_prints' of git://trac.sagemath.org/sage into t/24843/padic_prints`

sagetrac-git · 2018-07-25T00:22:23Z

Changed commit from debf1fc to c3af1bd

xcaruso · 2018-07-25T02:56:09Z

Changed branch from u/roed/padic_prints to u/caruso/padic_prints

sagetrac-git · 2018-07-25T20:36:57Z

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

`1453379`	`creduce after coercion from CA to its fraction field`
`5ffb263`	`replace creduce by normalize`
`7e842e3`	`Avoid to call two times cremove`
`618c61e`	`More reduce`
`b50388a`	`Working on fixing bugs in non-CR types`
`0145c56`	`Merge branch 'u/caruso/ramified_extensions_of_general_p_adic_rings_and_fields' of git://trac.sagemath.org/sage into t/23218/general_extensions`
`8d27ed7`	`Merge branch 'u/roed/ramified_extensions_of_general_p_adic_rings_and_fields' of trac.sagemath.org:sage into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields`
`8654e79`	`Make several methods work (or raise a NotImplementedError) for extensions`
`e156f7f`	`Write a test suite for the shifting operator`
`74f7fb9`	`Merge branch 't/23218/ramified_extensions_of_general_p_adic_rings_and_fields' into t/24843/padic_prints`

sagetrac-git · 2018-07-25T20:36:57Z

Changed commit from c3af1bd to 74f7fb9

xcaruso · 2018-07-25T20:37:49Z

Changed dependencies from #23450 to #23450, #23218

xcaruso · 2018-07-25T20:37:49Z

comment:15

I've merged this ticket with #23218 in order to be sure that they are not in conflit.

sagetrac-git · 2018-07-26T22:08:08Z

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

`cabb63e`	`Merge branch 'u/caruso/quo_rem_revision' of git://trac.sagemath.org/sage into t/21994/quo_rem_revision`
`4fed21f`	`Merge branch 't/21994/quo_rem_revision' into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields`
`aacb4c2`	`Merge branch 'u/roed/ramified_extensions_of_general_p_adic_rings_and_fields' of trac.sagemath.org:sage into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields`
`0ea13c0`	`Fix two bugs: one in expansion, one in cshift`
`22840e5`	`Prevent _test_log to compute log(0)`
`87f4c43`	`Always creduce after cremove`
`b1a3236`	`Remove unwanted print statements`
`31ae67d`	`Merge branch 't/23218/ramified_extensions_of_general_p_adic_rings_and_fields' into t/24843/padic_prints`
`9bce799`	`Fix docbuild problem`
`3104af8`	`Merge branch 'u/roed/ramified_extensions_of_general_p_adic_rings_and_fields' of trac.sagemath.org:sage into t/24843/padic_prints`

sagetrac-git · 2018-07-26T22:08:08Z

Changed commit from 74f7fb9 to 3104af8

roed314 · 2018-07-26T23:22:31Z

Changed branch from u/caruso/padic_prints to u/roed/padic_prints

sagetrac-git · 2018-07-27T08:07:26Z

Branch pushed to git repo; I updated commit sha1. New commits:

`0e6628d`	`Fix conversion from QqFP to QqCR`
`8576c59`	`Change construction functors for p-adics, making pushouts work in towers`
`b45a21e`	`Merge branch 'u/roed/ramified_extensions_of_general_p_adic_rings_and_fields' of trac.sagemath.org:sage into t/23218/ramified_extensions_of_general_p_adic_rings_and_fields`
`2d1a5c7`	`allow extension() method to accept implementation and prec arguments`
`bfe8ac7`	`Merge branch 't/23218/ramified_extensions_of_general_p_adic_rings_and_fields' into t/24843/padic_prints`
`b6cbd1d`	`Update polynomial printing, fix doctests`
`fcd4672`	`Fix a couple more doctest errors`

sagetrac-git · 2018-07-27T08:07:26Z

Changed commit from 3104af8 to fcd4672

sagetrac-git · 2018-07-27T08:14:06Z

Branch pushed to git repo; I updated commit sha1. New commits:

`dd5d0cd`	`Change ccmp to not short-circuit`
`b8a847d`	`Merge branch 't/23218/ramified_extensions_of_general_p_adic_rings_and_fields' into t/24843/padic_prints`

sagetrac-git · 2018-07-27T08:14:06Z

Changed commit from fcd4672 to b8a847d

xcaruso · 2018-07-28T09:14:56Z

Changed branch from u/roed/padic_prints to u/caruso/padic_prints

roed314 · 2018-07-29T18:01:56Z

Changed branch from u/caruso/padic_prints to u/roed/padic_prints

sagetrac-git · 2018-07-29T21:20:33Z

Changed commit from b8a847d to a736db8

sagetrac-git · 2018-07-29T21:20:33Z

Branch pushed to git repo; I updated commit sha1. New commits:

`a736db8`	`Fixing doctests due to changes in polynomial printing`

roed314 · 2018-07-29T21:47:10Z

comment:23

All tests pass. I'm happy with this ticket, if Xavier approves of my changes to polynomial printing.

xcaruso · 2018-07-30T04:13:33Z

comment:24

I do.

As for #23218, the patchbot reports failures but I think that they are not related to this ticket.

I give a positive review to this ticket. Feel free to revert this if you disagree.

vbraun · 2018-08-09T21:27:58Z

Changed branch from u/roed/padic_prints to a736db8

xcaruso added this to the sage-8.2 milestone Feb 26, 2018

xcaruso added c: padics labels Feb 26, 2018

xcaruso added the s: needs review label Feb 28, 2018

xcaruso added s: positive review and removed s: needs review labels Jul 30, 2018

vbraun removed the s: positive review label Aug 9, 2018

vbraun closed this as completed in 2e783bb Aug 9, 2018

xcaruso mentioned this issue Aug 9, 2018

Minimal polynomials of elements in p-adic fields #25103

Closed

Issue with p-adic printing #24843

Issue with p-adic printing #24843

Comments

xcaruso commented Feb 26, 2018

xcaruso commented Feb 28, 2018

xcaruso commented Feb 28, 2018

xcaruso commented Feb 28, 2018

xcaruso commented Feb 28, 2018

roed314 commented Feb 28, 2018

roed314 commented Feb 28, 2018

roed314 commented Feb 28, 2018

roed314 commented Feb 28, 2018

xcaruso commented Feb 28, 2018

sagetrac-git mannequin commented Feb 28, 2018

sagetrac-git mannequin commented Feb 28, 2018

roed314 commented Feb 28, 2018

sagetrac-git mannequin commented Feb 28, 2018

sagetrac-git mannequin commented Feb 28, 2018

roed314 commented Jul 22, 2018

sagetrac-git mannequin commented Jul 23, 2018

sagetrac-git mannequin commented Jul 23, 2018

roed314 commented Jul 25, 2018

sagetrac-git mannequin commented Jul 25, 2018

sagetrac-git mannequin commented Jul 25, 2018

xcaruso commented Jul 25, 2018

sagetrac-git mannequin commented Jul 25, 2018

sagetrac-git mannequin commented Jul 25, 2018

xcaruso commented Jul 25, 2018

xcaruso commented Jul 25, 2018

sagetrac-git mannequin commented Jul 26, 2018

sagetrac-git mannequin commented Jul 26, 2018

roed314 commented Jul 26, 2018

sagetrac-git mannequin commented Jul 27, 2018

sagetrac-git mannequin commented Jul 27, 2018

sagetrac-git mannequin commented Jul 27, 2018

sagetrac-git mannequin commented Jul 27, 2018

xcaruso commented Jul 28, 2018

roed314 commented Jul 29, 2018

sagetrac-git mannequin commented Jul 29, 2018

sagetrac-git mannequin commented Jul 29, 2018

roed314 commented Jul 29, 2018

xcaruso commented Jul 30, 2018

vbraun commented Aug 9, 2018