New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete docstrings and doctests for schemes/elliptic_curves #2485
Comments
comment:1
Hi John, I assume you're CCed on this. I am actively using the hyperelliptic curve code and have lots of things to fix/upgrade. Some of my work will touch schemes/elliptic_curves and I don't want to step on your toes. I'm CCed on this; when your patch is done I'll gladly referee it. Nick |
comment:2
Thanks Nick, that will be very helpful. It's unlikely that we will conflict. There is almost nothing I am planning to do except add to docstrings. John |
Attachment: 8866.patch.gz |
comment:3
The attached patch adds many docstrings to the following files (based on 2.10.3):
In addition there are a very few changes other than docstrings.
I hope all this will be found useful! There is still more to do in this directory: Overall weighted coverage score: 66.1% but a lot of that is explained by monsky_washnitzer.py: 23% (25 of 107) whci someone else will do, I hope. |
comment:4
I think this patch should be applied, because it is mostly good, but it's not perfect. I've noted a few nits below, only one of which (the KeyError) should be addressed before application. Thanks for your effort, John! This is probably not your bug, John, but it doesn't look right.
Also, I really worry about double underscore functions at all -- I say replace with single underscore; then doctesting isn't so strange.
This comment looks outdated, and should be removed:
I think things like
should be replaced with This is not very helpful -- I would prefer, "A ValueError is raised..."
and change the code to raise ValueError; it seems more appropriate than KeyError. |
Attachment: 8867.patch.gz Apply after 8866.patch |
comment:5
Thanks a lot for the fast review, Nick.
|
comment:7
Both patches apply cleanly against 2.10.3, and all doctests pass in sage/schemes/elliptic_curves/ The second patch appears to fix the issues brought up by the first reviewer, so I say "thumbs up". |
comment:8
Merged both patches in Sage 2.10.4.rc0 |
Following Doc Days 2 on 2008-03-09 I am working on making the docstrings and tests for schemes/elliptic_curves as complete as I can. A patch based on 2.10.3 will be posted here in time for 2.10.4, I hope.
CC: @ncalexan
Component: algebraic geometry
Issue created by migration from https://trac.sagemath.org/ticket/2485
The text was updated successfully, but these errors were encountered: