Fix signature of Matrix_gfpn_dense.__init__

[jdemeyer]

The signature of Matrix_gfpn_dense.__init__ is different from the other matrix constructors. Fix this.

CC: @simon-king-jena

Component: linear algebra

Author: Jeroen Demeyer

Branch/Commit: 3c079b2

Reviewer: Simon King

Issue created by migration from https://trac.sagemath.org/ticket/24863

[jdemeyer]

Branch: u/jdemeyer/fix_signature_of_matrix_gfpn_dense___init__

[jdemeyer]

Commit: 3c079b2

[jdemeyer]

comment:2

Simon: this is really part of #24742 but I made a separate ticket in case the particular __init__ signature is somehow important to you.

---

New commits:

3c079b2

Fix signature of Matrix_gfpn_dense.__init__

[simon-king-jena]

comment:3

Replying to @jdemeyer:

Simon: this is really part of #24742 but I made a separate ticket in case the particular __init__ signature is somehow important to you.

No, the commonly used signature is fine for me.

[jdemeyer]

comment:4

So, would you be willing to give positive review (assuming that tests pass)?

[jdemeyer]

comment:5

Note that the mutability parameter is non-standard, but I actually like it.

[simon-king-jena]

comment:6

Replying to @jdemeyer:

Note that the mutability parameter is non-standard, but I actually like it.

I am not sure if I actually use that parameter, but if possible I'd prefer it to be preserved.

The patchbot complains about a non-ascii character. Apart from that, it would be positive review.

[jdemeyer]

Reviewer: Simon King

[jdemeyer]

comment:7

Replying to @simon-king-jena:

The patchbot complains about a non-ascii character.

I don't think so. It looks like the patchbot plugin itself is generating a UnicodeDecodeError.

[jdemeyer]

comment:8

Note that the code of Matrix_gfpn_dense.__init__ will change completely in #24742, but those should make no functional difference.

[vbraun]

Changed branch from u/jdemeyer/fix_signature_of_matrix_gfpn_dense___init__ to 3c079b2