Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement one-point suspension and face split of polyhedron #24886

Closed
jplab opened this issue Mar 2, 2018 · 19 comments
Closed

Implement one-point suspension and face split of polyhedron #24886

jplab opened this issue Mar 2, 2018 · 19 comments

Comments

@jplab
Copy link

jplab commented Mar 2, 2018

The one-point suspension of a vertex v of a polyhedron P of dimension d is obtained by placing P in a dimension d+1 vector space where the last coordinate is 0, then placing a vertex "over" v and a vertex "below" v in the last coordinate and taking the convex hull.

One can do a similar construction for faces of polyhedron by placing the two vertices relative to the center of the face. This way we get the face split of P.

On the way, the center function also got modified in the case when it is only a vertex so that it returns the vertex. This was necessary to make the one-point suspension consistent.

CC: @videlec @mo271 @mkoeppe @fchapoton

Component: geometry

Keywords: days93, polytope, thursdaysbdx, IMA-PolyGeom

Author: Jean-Philippe Labbé

Branch/Commit: 2d78b87

Reviewer: Frédéric Chapoton, Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/24886

@jplab jplab added this to the sage-8.2 milestone Mar 2, 2018
@jplab
Copy link
Author

jplab commented Mar 2, 2018

Branch: u/jipilab/24886

@jplab
Copy link
Author

jplab commented Mar 2, 2018

New commits:

32f0e86first version of ops
eeee559Second version of ops
2dacbe1whitespaces

@jplab
Copy link
Author

jplab commented Mar 2, 2018

Commit: 2dacbe1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 6, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

02fa0d9Merge branch 'sage8.2.b7' into onepointsus

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 6, 2018

Changed commit from 2dacbe1 to 02fa0d9

@videlec
Copy link
Contributor

videlec commented Mar 8, 2018

comment:4

typo: the face splitting the face ``face``

@videlec
Copy link
Contributor

videlec commented Mar 8, 2018

comment:5

You should check that you obtain the same answer using a proper vertex or a face of dimension 0

sage: C = polytopes.cube()
sage: C.faces(0)    # dimension 0 faces
(<0>, <1>, <2>, <3>, <4>, <5>, <6>, <7>)
sage: C.vertices()  # proper vertices
(A vertex at (-1, -1, -1),
 A vertex at (-1, -1, 1),
...
 A vertex at (1, 1, 1))

@videlec
Copy link
Contributor

videlec commented Mar 8, 2018

comment:6

The documentation would also be nicer with:

  • a proper definition of bypiramid
  • specification that the newly added vertices will be at height -1 and 1

@videlec
Copy link
Contributor

videlec commented Mar 8, 2018

Changed keywords from days93, polytope to days93, polytope, thursdaysbdx

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 9, 2018

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

7f5e125fixed typos in polyhedra_quickref.rst
bd6c356LateX -> LaTeX in polytope_tikz.rst
b1ce45bSeveral other corrections
d526f70renamed tutorial files
d7896f8Merge branch 'develop' into 22572
597b802Merge branch sage8.2.rc1 into 22572
eee533aCorrections from review
b74ae85Made tests pass
1c9a654Merge branch thematic tutorial into onepointsus
eef860fApplied review suggestions

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 9, 2018

Changed commit from 02fa0d9 to eef860f

@jplab
Copy link
Author

jplab commented Apr 9, 2018

Changed keywords from days93, polytope, thursdaysbdx to days93, polytope, thursdaysbdx, IMA-PolyGeom

@jplab
Copy link
Author

jplab commented Apr 9, 2018

comment:9

Hi,

Thanks Vincent for your review. I made the suggested changes (along with merging the tutorial).

I realized while making a test that the method center was changing the base ring when it was taken over a vertex, I fixed that small thing on the way too.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 9, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

2d78b87whitespaces

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 9, 2018

Changed commit from eef860f to 2d78b87

@jplab

This comment has been minimized.

@jplab jplab changed the title Implement one point suspension and face split of polyhedron Implement one-point suspension and face split of polyhedron Apr 11, 2018
@fchapoton
Copy link
Contributor

comment:12

ok, let it be too

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton, Vincent Delecroix

@fchapoton fchapoton modified the milestones: sage-8.2, sage-8.3 Jun 25, 2018
@vbraun
Copy link
Member

vbraun commented Jun 29, 2018

Changed branch from u/jipilab/24886 to 2d78b87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants