Enumerate all genera of given signature, determinant and bounded scale of a jordan block.

[simonbrandhorst]

Create a function that enumerates all genera of a given signature, determinant and with bounded scale of a jordan block.
The output should belong to sage.quadratic_forms.genera.Genus .

Depends on #24897
Depends on #25875

CC: @annahaensch

Component: quadratic forms

Author: Simon Brandhorst

Branch/Commit: 347320d

Reviewer: Travis Scrimshaw, Ursula Whitcher

Issue created by migration from https://trac.sagemath.org/ticket/24889

[simonbrandhorst]

Branch: u/sbrandhorst/enumerate_all_genera_of_given_signature__determinant_and_bounded_scale_of_a_jordan_block_

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

e678deb	Small fixes.
37adad4	Merge branch 'develop' of git://trac.sagemath.org/sage into t/24889/enumerate_all_genera_of_given_signature__determinant_and_bounded_scale_of_a_jordan_block_
876819c	24897: fix Cantor product with factors of length 1
9e05a0d	Merge branch 'u/vdelecroix/24897' of git://trac.sagemath.org/sage into t/24889/enumerate_all_genera_of_given_signature__determinant_and_bounded_scale_of_a_jordan_block_
2606df0	A first working version.

[sagetrac-git]

Commit: 2606df0

[simonbrandhorst]

Dependencies: #24897

[sagetrac-git]

Changed commit from 2606df0 to c1f9bbc

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

c1f9bbc

Merge branch 'develop' into t/24889/enumerate_all_genera_of_given_signature__determinant_and_bounded_scale_of_a_jordan_block_

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

ffba0e4

Enumeration of canonical symbols. This is faster but has other problems...

[sagetrac-git]

Changed commit from c1f9bbc to ffba0e4

[sagetrac-git]

Changed commit from ffba0e4 to e2b9be0

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

e2b9be0

Merge branch 'develop' into t/24889/enumerate_all_genera_of_given_signature__determinant_and_bounded_scale_of_a_jordan_block_

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

52c15eb

Clean up

[sagetrac-git]

Changed commit from e2b9be0 to 52c15eb

[simonbrandhorst]

Author: Simon Brandhorst

[sagetrac-git]

Changed commit from 52c15eb to 1701994

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

a17edfe	Merge branch 'develop' into t/24889/enumerate_all_genera_of_given_signature__determinant_and_bounded_scale_of_a_jordan_block_
1701994	fixed a doctest

[sagetrac-git]

Changed commit from 1701994 to add11fa

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

add11fa

Merge branch 'develop' into t/24889/enumerate_all_genera_of_given_signature__determinant_and_bounded_scale_of_a_jordan_block_

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

08e63db	Merge branch 'develop' into t/24889/enumerate_all_genera_of_given_signature__determinant_and_bounded_scale_of_a_jordan_block_
7f53b1d	Merge branch 'develop' into t/24889/enumerate_all_genera_of_given_signature__determinant_and_bounded_scale_of_a_jordan_block_
6f393f7	docfix

[sagetrac-git]

Changed commit from add11fa to 6f393f7

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

5fca826	Documentation and access methods for the genus
de444a0	Merge branch 'u/sbrandhorst/add_access_methods_to_the_genus_' of git://trac.sagemath.org/sage into t/25875/make_genera_immutable_and_add_a_reasonable_constructor
bba1834	Construct a genus from a symbol list
b33dd62	fix coverage
69b0811	Merge branch 't/25682/add_access_methods_to_the_genus_' into t/25875/make_genera_immutable_and_add_a_reasonable_constructor
56b3994	Add keyword factored determinant for the genus
d63626c	Merge branch 't/25875/make_genera_immutable_and_add_a_reasonable_constructor' into t/24889/enumerate_all_genera_of_given_signature__determinant_and_bounded_scale_of_a_jordan_block_
e3d938f	fix copy import and make output order deterministic

[sagetrac-git]

Changed commit from 6f393f7 to e3d938f

[simonbrandhorst]

Changed dependencies from #24897 to #24897,#25683

[simonbrandhorst]

Changed dependencies from #24897,#25683 to #24897,#25875

[simonbrandhorst]

comment:29

After a second thought I do not want to make them iterators.
For one iterators are less convenient for the user. Further
for the 2-adic symbols we are overcounting and then removing duplicates.
I do not see how to do this properly with an iterator.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

8742cd1

cosmetics

[sagetrac-git]

Changed commit from fb0008c to 8742cd1

[sagetrac-git]

Changed commit from 8742cd1 to 621a9f5

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

621a9f5

change name to genera

[simonbrandhorst]

comment:32

Ursula suggested QuadraticFormsGenera that is more specific than just genera, yet it is still relatively easy to discover starting from QuadraticForm

[sagetrac-ursula]

comment:33

The patch builds and the example works. I still think it's more intuitive Sage syntax to have a top-level object with an associated enumeration method, rather than a function that's not associated to an object.

[simonbrandhorst]

comment:34

Ouf, let us ask on sage devel. There are reasons for and against both.

[simonbrandhorst]

comment:35

https://groups.google.com/forum/#!topic/sage-devel/M-8VL0LnKhU

[simonbrandhorst]

comment:36

Writing in the quadratic forms class

    from sage.quadratic_forms.genera.genus import genera

works.
But

    @staticmethod
    from sage.quadratic_forms.genera.genus import genera

crashes. Ideas?

[tscrim]

comment:37

The latter does not make sense (at least with the context given here). genera is a function, so why should it be a @staticmethod?

I do not like QuadraticFormsGenera because it is a function, not a class. So following Python naming conventions, I would use quadratic_forms_genera.

@sagetrac-ursula The use for making this an object depends on how you use it. Fundamentally there is little computational overhead for making this into some Parent or CategoryObject, but there is some implementation burden. If it is not going to be a subclass of one of those, then I am not sure there would be a good reason to make it into an object (rather than a function). (Technical aside: this is more of a question about semantics rather than syntax.)

[sagetrac-git]

Changed commit from 621a9f5 to 347320d

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

347320d

added static method genera to the class QuadraticForm

[simonbrandhorst]

comment:39

staticmethod(genera) worked.
Now it is the static method
QuadraticForm.genera

[tscrim]

comment:41

@sagetrac-ursula You need your (real) name as a reviewer.

[tscrim]

Reviewer: Travis Scrimshaw

[sagetrac-ursula]

Changed reviewer from Travis Scrimshaw to Travis Scrimshaw, Ursula Whitcher

[vbraun]

Changed branch from u/sbrandhorst/enumerate_all_genera_of_given_signature__determinant_and_bounded_scale_of_a_jordan_block_ to 347320d