Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optional package deformation fails to build #24902

Closed
videlec opened this issue Mar 5, 2018 · 10 comments
Closed

optional package deformation fails to build #24902

videlec opened this issue Mar 5, 2018 · 10 comments

Comments

@videlec
Copy link
Contributor

videlec commented Mar 5, 2018

On archlinux

/usr/bin/ld: -r and -pie may not be used together

See the more complete log attachment: deformation-d05941b.log.

Upstream report: jpflori/pydeformation#5

A patch is provided in #24575.

CC: @jpflori

Component: packages: optional

Issue created by migration from https://trac.sagemath.org/ticket/24902

@videlec videlec added this to the sage-8.2 milestone Mar 5, 2018
@videlec

This comment has been minimized.

@videlec
Copy link
Contributor Author

videlec commented Mar 5, 2018

comment:1

Attachment: deformation-d05941b.log

@kiwifb
Copy link
Member

kiwifb commented Mar 5, 2018

comment:2

Flint had that issue some time ago. This is caused by the hardening of the toolchain. Look at what has been done for flint here
https://github.com/sagemath/sage-prod/blob/master/build/pkgs/flint/patches/flint-pie-hardening-conflict.patch. Basically you give -r directly to the compiler but don't pass it directly to the linker as you would with -Wl,-r.

@kiwifb
Copy link
Member

kiwifb commented Mar 6, 2018

comment:4

The culprit is this line

Makefile.subdirs:       $(QUIET_CC) $(CC) $(ABI_FLAG) -Wl,-r $^ -o $@ -nostdlib

Change -Wl,-r to plain -r should get you in business. Can someone also please update SPKG.txt with upstream location? Where did you get that tarball from? Has it been processed before being put on the mirror?

@videlec
Copy link
Contributor Author

videlec commented Mar 8, 2018

comment:5

A patch is provided in #24575, should I move it here?

@videlec
Copy link
Contributor Author

videlec commented Mar 8, 2018

comment:6

Replying to @videlec:

A patch is provided in #24575, should I move it here?

@kiwifb
Copy link
Member

kiwifb commented Mar 8, 2018

comment:7

No need we can just mark this ticket as a "duplicate" of #24575.

@videlec

This comment has been minimized.

@videlec videlec removed this from the sage-8.2 milestone Mar 8, 2018
@videlec

This comment has been minimized.

@videlec
Copy link
Contributor Author

videlec commented May 18, 2018

comment:12

closing positively reviewed duplicates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants