Sage does not build on vfat filesystems

[jdemeyer]

This check in build/bin/sage-spkg should really depend on the filesystem and not on the OS:

                msg="$script should not be marked executable in the build/pkgs directory"
                if [ "$UNAME" = "CYGWIN" ]; then
                    # On Cygwin we can't necessarily rely on file permissions
                    # being sane, so just issue a warning; on other platforms
                    # this should be enforced as an error
                    echo >&2 "WARNING: $msg"
                else
                    error_msg "$msg"
                    exit 1
                fi

CC: @embray

Component: build

Issue created by migration from https://trac.sagemath.org/ticket/24953

[saraedum]

comment:1

I took the liberty to downgrade this. I don't see why this would be critical. Feel free to set it back.

Of course this check is wrong in theory, but at the moment I feel it's good enough. We could change the comment by replacing "Cygwin" with "vfat & friends" but it's not worth to figure out the file system from my point of view.

[embray]

comment:2

I think also lots of other things will go wrong if you try to build on a VFAT filesystem.

[saraedum]

comment:3

If jdemeyer agrees, we should close this.

[jdemeyer]

comment:4

Replying to @embray:

I think also lots of other things will go wrong if you try to build on a VFAT filesystem.

Like symlinks I guess?

[jdemeyer]

comment:5

Duplicate of #25207

[embray]

comment:6

I guess really #25207 could be considered a duplicate of this ticket, albeit a bit broader in scope.

I'm still not sure about FAT if you can't have symlinks though...