Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add parameter solver to comparability methods #24976

Closed
dcoudert opened this issue Mar 14, 2018 · 14 comments
Closed

add parameter solver to comparability methods #24976

dcoudert opened this issue Mar 14, 2018 · 14 comments

Comments

@dcoudert
Copy link
Contributor

Part of #20416.

  • add arguments solver and verbose to methods in src/sage/graphs/comparability.pyx
  • clean some links

CC: @mkoeppe @jm58660

Component: graph theory

Author: David Coudert

Branch/Commit: 85823d9

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/24976

@dcoudert dcoudert added this to the sage-8.2 milestone Mar 14, 2018
@dcoudert
Copy link
Contributor Author

Branch: u/dcoudert/24976_comparability

@dcoudert
Copy link
Contributor Author

New commits:

ae96863trac #24976: add parameters solver and verbose to methods in comparability

@dcoudert
Copy link
Contributor Author

Commit: ae96863

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 13, 2018

Changed commit from ae96863 to bf81c5a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 13, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

bf81c5atrac #24976: Merged with 8.3.beta0

@dcoudert dcoudert modified the milestones: sage-8.2, sage-8.3 May 13, 2018
@tscrim
Copy link
Collaborator

tscrim commented May 13, 2018

comment:4

Just some PEP8 nitpicks:

def is_comparability(g, algorithm="greedy", certificate=False, check=True,
                     solver=None, verbose=0):
        comparability_test = is_comparability_MILP(g, certificate=certificate,
                                                   solver=solver, verbose=verbose)
        return (is_comparability(g, algorithm=algorithm, solver=solver, verbose=verbose) and
                is_comparability(g.complement(), algorithm=algorithm, solver=solver, verbose=verbose))

(and similar).
Once changed (or ignored), you can set a positive review on my behalf.

@tscrim
Copy link
Collaborator

tscrim commented May 13, 2018

Reviewer: Travis Scrimshaw

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 15, 2018

Changed commit from bf81c5a to a0b8396

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 15, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

a0b8396trac #24976: PEP8

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 12, 2018

Changed commit from a0b8396 to 85823d9

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 12, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

85823d9trac #24976: Merged with 8.3.beta5

@dcoudert dcoudert changed the title add parameter solver to method comparability methods add parameter solver to comparability methods Jun 12, 2018
@dcoudert
Copy link
Contributor Author

comment:8

Once changed (or ignored), you can set a positive review on my behalf.

I have not set this ticket to positive review. Can I ?

@tscrim
Copy link
Collaborator

tscrim commented Jun 24, 2018

comment:9

Sorry, because I am not on cc, simple pushes do not send me email updates. Yep, LGTM. Thanks.

@vbraun
Copy link
Member

vbraun commented Jun 26, 2018

Changed branch from u/dcoudert/24976_comparability to 85823d9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants