Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup in plot3d #25036

Closed
jdemeyer opened this issue Mar 27, 2018 · 8 comments
Closed

Code cleanup in plot3d #25036

jdemeyer opened this issue Mar 27, 2018 · 8 comments
Labels
c: graphics p: major / 3 t: enhancement
Milestone
sage-8.2

Comments

@jdemeyer
Copy link

This contains a bunch of fixes which I did while working on #13135. This is just a clean-up, no functionality is changed.

Component: graphics

Author: Jeroen Demeyer

Branch/Commit: b1d6862

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/25036
@jdemeyer jdemeyer added this to the sage-8.2 milestone Mar 27, 2018
@jdemeyer
Copy link
Author

Branch: u/jdemeyer/ticket/25036

@jdemeyer
Copy link
Author

Commit: 4a9e317

@jdemeyer
Copy link
Author

New commits:

4a9e317Code cleanup in plot3d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 27, 2018

Changed commit from 4a9e317 to b1d6862

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 27, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

b1d6862This test takes a long time

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:4

ok

@vbraun
Copy link
Member

vbraun commented May 12, 2018

Changed branch from u/jdemeyer/ticket/25036 to b1d6862

@vbraun vbraun closed this as completed in fbcf504 May 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: graphics p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.2
Development

No branches or pull requests
3 participants
@vbraun @jdemeyer @fchapoton