Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add destdir support and other cleanup for ntl #25037

Closed
embray opened this issue Mar 27, 2018 · 8 comments
Closed

Add destdir support and other cleanup for ntl #25037

embray opened this issue Mar 27, 2018 · 8 comments

Comments

@embray
Copy link
Contributor

embray commented Mar 27, 2018

This is #24024 for ntl

Depends on #25001
Depends on #23733

Component: build

Keywords: destdir ntl

Author: Erik Bray

Branch/Commit: 12a153e

Reviewer: Julian Rüth

Issue created by migration from https://trac.sagemath.org/ticket/25037

@embray embray added this to the sage-8.2 milestone Mar 27, 2018
@jdemeyer
Copy link

comment:2

I think that this

     # Touch all includes such that dependency checking works properly:
     # the timestamp of the includes should be *now*, not the time when
     # the NTL package was created.
-    touch "$SAGE_LOCAL"/include/NTL/*
+    touch "$SAGE_DESTDIR_LOCAL"/include/NTL/*

is actually fixed by your changes to the tarball extraction, fixing the timestamps to the time of installation.

@embray
Copy link
Contributor Author

embray commented Mar 28, 2018

comment:3

Ah, probably true; I will double-check that and remove those lines if so.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 30, 2018

Changed commit from c3e89ce to 12a153e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 30, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

12a153eremove crud for touching extracted files; no longer needed since #24567

@saraedum
Copy link
Member

saraedum commented Apr 1, 2018

Reviewer: Julian Rüth

@embray
Copy link
Contributor Author

embray commented Apr 4, 2018

Changed dependencies from #25001 to #25001 #23733

@embray
Copy link
Contributor Author

embray commented Apr 4, 2018

comment:7

(already merges without conflict with #23733)

@embray embray modified the milestones: sage-8.2, sage-8.3 Apr 26, 2018
@vbraun
Copy link
Member

vbraun commented May 12, 2018

Changed branch from u/embray/build/destdir-ntl to 12a153e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants