Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update additional packages to use sdh_install #25040

Closed
embray opened this issue Mar 27, 2018 · 18 comments
Closed

Update additional packages to use sdh_install #25040

embray opened this issue Mar 27, 2018 · 18 comments

Comments

@embray
Copy link
Contributor

embray commented Mar 27, 2018

This updates packages that do nothing more than copy some files to use sdh_install from #25039:

  • combinatorial_designs
  • graphs
  • pari_galdata
  • pari_seadata_small
  • polytopes_db
  • threejs

Excluded jmol from this since it's slightly more complicated, and would conflict with #25026.

Depends on #25039

Component: build

Keywords: destdir combinatorial_designs graphs pari_galdata pari_seadata_small polytopes_db threejs

Author: Erik Bray

Branch: cede25d

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/25040

@embray embray added this to the sage-8.2 milestone Mar 27, 2018
@jdemeyer
Copy link

Reviewer: Jeroen Demeyer

@jdemeyer
Copy link

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 11, 2018

Changed commit from 5c43762 to 0023321

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 11, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

fa991casdh_install_files -> sdh_install in error messages
a75add4Packages that simply copy files over--update to use sdh_install
0023321update package versions for buildbot

@jdemeyer
Copy link

comment:5

Rebased to latest version of #25039

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 11, 2018

Changed commit from 0023321 to 88e5780

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 11, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

88e5780Unify install scripts of PARI databases

@jdemeyer
Copy link

comment:7

I added one extra commit to deal with all PARI databases. If you agree, set this ticket to positive review.

@embray
Copy link
Contributor Author

embray commented Apr 11, 2018

comment:8

Yes, that makes sense.

@vbraun
Copy link
Member

vbraun commented May 17, 2018

comment:10

Merge conflict

@embray
Copy link
Contributor Author

embray commented May 18, 2018

New commits:

52d66b4Packages that simply copy files over--update to use sdh_install
5c43762update package versions for buildbot

@embray
Copy link
Contributor Author

embray commented May 18, 2018

@embray
Copy link
Contributor Author

embray commented May 18, 2018

Changed commit from 88e5780 to 5c43762

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 18, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

b0b38c2Adds a new sdh_install helper function:
852cb5ffix bug in handling of the -T flag--it was as if it was always set
5f7cd30fix bug that can occur in repeated invocations of sdh_install in the same script
daa37d5various minor review comments
0f848c3sdh_install_files -> sdh_install in error messages
d7440eaPackages that simply copy files over--update to use sdh_install
0c84a71update package versions for buildbot
cede25dUnify install scripts of PARI databases

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 18, 2018

Changed commit from 5c43762 to cede25d

@vbraun
Copy link
Member

vbraun commented May 19, 2018

Changed branch from u/embray/build/destdir-simple-copy to cede25d

@egourgoulhon
Copy link
Member

comment:16

See #25665 for a follow up (issue with threejs).

@egourgoulhon
Copy link
Member

Changed commit from cede25d to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants