Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: get rid of __cmp__ in interfaces #25063

Closed
fchapoton opened this issue Mar 30, 2018 · 9 comments
Closed

py3: get rid of __cmp__ in interfaces #25063

fchapoton opened this issue Mar 30, 2018 · 9 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.2

Comments

@fchapoton
Copy link
Contributor

part of #16537

CC: @embray @jdemeyer @kiwifb

Component: python3

Keywords: richcmp

Author: Frédéric Chapoton

Branch/Commit: 013ba7e

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/25063
@fchapoton fchapoton added this to the sage-8.2 milestone Mar 30, 2018
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/25063

@fchapoton
Copy link
Contributor Author

New commits:

e21f2cdget rid of `__cmp__` in interfaces

@fchapoton
Copy link
Contributor Author

Commit: e21f2cd

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 31, 2018

Changed commit from e21f2cd to 013ba7e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 31, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

013ba7etrac 25063 fix detail

@fchapoton
Copy link
Contributor Author

comment:3

bot is green, please review

@tscrim
Copy link
Collaborator

tscrim commented Mar 31, 2018

comment:4

A bit of technical debt, but it is somewhat elegant in its simplicity.

@tscrim
Copy link
Collaborator

tscrim commented Mar 31, 2018

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented May 12, 2018

Changed branch from u/chapoton/25063 to 013ba7e

@vbraun vbraun closed this as completed in 7f5a1da May 12, 2018
@wluebbe wluebbe mannequin mentioned this issue Sep 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.2
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton