Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DESTDIR support for zn_poly, and additional cleanup #25085

Closed
embray opened this issue Apr 3, 2018 · 17 comments
Closed

Add DESTDIR support for zn_poly, and additional cleanup #25085

embray opened this issue Apr 3, 2018 · 17 comments

Comments

@embray
Copy link
Contributor

embray commented Apr 3, 2018

A bit of cleanup for zn_poly's spkg-install:

1) Implement DESTDIR support and use sage-dist-helpers where useful (#24024)

2) Remove SAGE64 support (#23733)

3) Improve Cygwin support--in particular don't install .so files to lib/ (#14208)

Depends on #25039
Depends on #23733

Component: build

Keywords: destdir zn_poly cygwin

Author: Erik Bray

Branch/Commit: a677f80

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/25085

@embray embray added this to the sage-8.2 milestone Apr 3, 2018
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 3, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

cd59a43A bit of cleanup for zn_poly's spkg-install:

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 3, 2018

Changed commit from ef1135e to cd59a43

@embray
Copy link
Contributor Author

embray commented Apr 3, 2018

Dependencies: #25039

@embray
Copy link
Contributor Author

embray commented Apr 3, 2018

comment:2

I still need to test this on Cygwin (it should be fine on OSX, but the changes on Cygwin are substantive). If it works it should also finally resolve #14208, as zn_poly.so is the last library being installed on Cygwin as a ".so".

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 4, 2018

Changed commit from cd59a43 to 1572604

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 4, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

b4ecda9trac 23733: deprecate SAGE64 and CFLAG64
905e4d4Stop supporting SAGE64 except in Numpy
1572604Merge branch 'u/jdemeyer/no-sage64' into u/embray/build/destdir-zn_poly

@embray
Copy link
Contributor Author

embray commented Apr 4, 2018

Changed dependencies from #25039 to #25039, #23733

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 5, 2018

Changed commit from 1572604 to 8168d98

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 5, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

8168d98bit of a pain...

@embray embray modified the milestones: sage-8.2, sage-8.3 Apr 26, 2018
@embray
Copy link
Contributor Author

embray commented Jul 7, 2018

Changed keywords from destdir zn_poly to destdir zn_poly cygwin

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 7, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

aed63edA bit of cleanup for zn_poly's spkg-install:
a677f80bit of a pain...

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 7, 2018

Changed commit from 8168d98 to a677f80

@embray
Copy link
Contributor Author

embray commented Jul 7, 2018

comment:9

Rebased. Not sure why this wasn't needs_review--perhaps I was just waiting on its dependencies.

@tscrim
Copy link
Collaborator

tscrim commented Jul 7, 2018

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jul 7, 2018

comment:10

LGTM.

@embray
Copy link
Contributor Author

embray commented Jul 18, 2018

comment:11

I believe this issue can reasonably be addressed for Sage 8.4.

@embray embray modified the milestones: sage-8.3, sage-8.4 Jul 18, 2018
@vbraun
Copy link
Member

vbraun commented Aug 5, 2018

Changed branch from u/embray/build/destdir-zn_poly to a677f80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants