Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use year of release for copyright #25093

Closed
saraedum opened this issue Apr 3, 2018 · 11 comments
Closed

Use year of release for copyright #25093

saraedum opened this issue Apr 3, 2018 · 11 comments

Comments

@saraedum
Copy link
Member

saraedum commented Apr 3, 2018

not the year of the build.

Currently, Debian patches Sage to get a stable copyright information:

Description: Generate documentation reproducibly
 TODO: make this use SOURCE_DATE_EPOCH instead which is set automatically by debhelper
 https://wiki.debian.org/ReproducibleBuilds/TimestampsProposal#Python
Author: Ximin Luo <infinity0@debian.org>
Forwarded: TODO
---
This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
--- a/sage/src/doc/common/conf.py
+++ b/sage/src/doc/common/conf.py
@@ -61,7 +61,7 @@
 
 # General information about the project.
 project = u""
-copyright = u"2005--{}, The Sage Development Team".format(date.today().year)
+copyright = u"2005--2016, The Sage Development Team"
 
 # The version info for the project you're documenting, acts as replacement for
 # |version| and |release|, also used in various other places throughout the

Since version.date already contains the date of the release, we should just use that instead.

CC: @infinity0

Component: documentation

Keywords: debian

Author: Julian Rüth

Branch/Commit: a69f4b2

Reviewer: Ximin Luo

Issue created by migration from https://trac.sagemath.org/ticket/25093

@saraedum saraedum added this to the sage-8.2 milestone Apr 3, 2018
@saraedum
Copy link
Member Author

saraedum commented Apr 3, 2018

Branch: u/saraedum/sage-doc-year

@saraedum
Copy link
Member Author

saraedum commented Apr 3, 2018

Commit: a69f4b2

@saraedum

This comment has been minimized.

@saraedum
Copy link
Member Author

saraedum commented Apr 3, 2018

New commits:

a69f4b2Use year of release in copyright

@saraedum

This comment has been minimized.

@infinity0
Copy link
Mannequin

infinity0 mannequin commented Apr 3, 2018

comment:5

Looks good to me, thanks for doing this and all the other tickets! I am not a Sage dev though so not sure I can officially "pass" the review. However, I will for sure add it to the Debian package when I next touch that.

@saraedum
Copy link
Member Author

saraedum commented Apr 3, 2018

comment:6

http://doc.sagemath.org/html/en/developer/reviewer_checklist.html says "Anybody (e.g. you) can do this job for somebody else’s ticket."

But I understand if you want to wait for a more established dev to take a look at this.

Btw., it would be great if you could add your real name to trac.sagemath.org.

@jdemeyer
Copy link

jdemeyer commented Apr 4, 2018

comment:7

Replying to @infinity0:

I am not a Sage dev though so not sure I can officially "pass" the review.

You can. But the author should set the ticket to needs_review first.

@fchapoton
Copy link
Contributor

comment:10

missing reviewer's name

@saraedum
Copy link
Member Author

Reviewer: Ximin Luo

@loefflerd loefflerd mannequin modified the milestones: sage-8.2, sage-8.3 May 17, 2018
@vbraun
Copy link
Member

vbraun commented May 18, 2018

Changed branch from u/saraedum/sage-doc-year to a69f4b2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants