Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factoring disconnected graph #25126

Closed
jm58660 mannequin opened this issue Apr 9, 2018 · 11 comments
Closed

Factoring disconnected graph #25126

jm58660 mannequin opened this issue Apr 9, 2018 · 11 comments
Labels
c: graph theory p: minor / 4 t: bug
Milestone
sage-8.3

Comments

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Apr 9, 2018

Currently Graph(4).is_cartesian_product() raises ValueError and Graph(5).is_cartesian_product() returns False. This patch makes both to raise NotImplementedError.

CC: @fchapoton

Component: graph theory

Author: Jori Mäntysalo

Branch/Commit: 1efb9ba

Reviewer: David Coudert

Issue created by migration from https://trac.sagemath.org/ticket/25126
@jm58660 jm58660 mannequin added this to the sage-8.2 milestone Apr 9, 2018
@jm58660 jm58660 mannequin added c: graph theory labels Apr 9, 2018
@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Apr 9, 2018

Branch: u/jmantysalo/factor-unconnected

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Apr 9, 2018

Commit: 6e068fc

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Apr 9, 2018

New commits:

6e068fcChange error type.

@jm58660 jm58660 mannequin added the s: needs review label Apr 9, 2018
@dcoudert
Copy link
Contributor

comment:3

Please use either "disconnected" or "non connected", but not "unconnected" that I have never seen in any graph theory paper.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 11, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

1efb9ba'unconnected' -> 'disconnected'.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 11, 2018

Changed commit from 6e068fc to 1efb9ba

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Apr 11, 2018

comment:5

Replying to @dcoudert:

Please use either "disconnected" or "non connected", but not "unconnected" that I have never seen in any graph theory paper.

Good point, corrected.

@dcoudert
Copy link
Contributor

Reviewer: David Coudert

@dcoudert
Copy link
Contributor

comment:6

Thanks.

I changed the title of the ticket.

@dcoudert dcoudert changed the title Factoring unconnected graph Factoring disconnected graph Apr 11, 2018
@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Apr 11, 2018

comment:7

Replying to @dcoudert:

I changed the title of the ticket.

Another good point. Another thanks.

@jm58660 jm58660 mannequin modified the milestones: sage-8.2, sage-8.3 Apr 17, 2018
@vbraun
Copy link
Member

vbraun commented May 18, 2018

Changed branch from u/jmantysalo/factor-unconnected to 1efb9ba

@vbraun vbraun closed this as completed in fdce8e4 May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: graph theory p: minor / 4 t: bug
Projects
None yet
Milestone
sage-8.3
Development

No branches or pull requests
2 participants
@vbraun @dcoudert