Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add monomial basis to FQSym #25136

Closed
tscrim opened this issue Apr 10, 2018 · 30 comments
Closed

Add monomial basis to FQSym #25136

tscrim opened this issue Apr 10, 2018 · 30 comments

Comments

@tscrim
Copy link
Collaborator

tscrim commented Apr 10, 2018

The monomial basis of Aguiar and Sottile (see 1.3 in ​http://www.math.tamu.edu/~sottile/research/pdf/SSym.pdf ; the formula (1.13) is most important, and triangularity should do the rest, if we make sure that the order is right).

Depends on #25131
Depends on #25141

CC: @sagetrac-sage-combinat @darijgr @alauve @zabrocki @saliola @amypang

Component: combinatorics

Keywords: IMA coding sprint, CHAs, permutations

Author: Darij Grinberg

Branch: 8dc0c5c

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/25136

@tscrim tscrim added this to the sage-8.2 milestone Apr 10, 2018
@darijgr
Copy link
Contributor

darijgr commented Apr 11, 2018

Branch: public/combinat/fqsym2

@darijgr
Copy link
Contributor

darijgr commented Apr 11, 2018

Commit: e79d2d3

@darijgr
Copy link
Contributor

darijgr commented Apr 11, 2018

Author: Darij Grinberg

@darijgr
Copy link
Contributor

darijgr commented Apr 11, 2018

New commits:

acf384bG-basis and bugfixes
e79d2d3Merge branch 'public/combinat/fqsym' of trac.sagemath.org:sage into fq2

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 11, 2018

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

5dc2bfeMerge branch 'public/combinat/wqsym2' of git://trac.sagemath.org/sage into public/combinat/wqsym2
85634b2outsource to_ordered_set_partition
72bcd46implement the inclusion FQSym -> WQSym
a5512edpolish Travis's edits
7394bf7Added deprecations to Bases.ParentMethod.to_ncsym(_on_basis).
235f69bimplement the inclusion NCSym -> WQSym
58d17adMerge branch 'public/combinat/wqsym_morphisms-25141' of trac.sagemath.org:sage into fq2
7dd85ffimplement the M basis of FQSym
faad461fix documentation
2acec00Merge branch 'WQS' into fq2

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 11, 2018

Changed commit from e79d2d3 to 2acec00

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 11, 2018

Changed commit from 2acec00 to 78a4253

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 11, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

78a4253overload coproduct on M-basis for speed

@darijgr
Copy link
Contributor

darijgr commented Apr 11, 2018

Changed dependencies from #25131 to #25131, #25141

@darijgr
Copy link
Contributor

darijgr commented Apr 11, 2018

comment:4

There it is. (I'm Darij, logging in through github.)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 11, 2018

Changed commit from 78a4253 to ef1f3b7

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 11, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

ef1f3b7link FQSym doc

@darijgr
Copy link
Contributor

darijgr commented Apr 12, 2018

comment:6

PS. Since the branch has become rather tortuous, here are all the commits that need reviewing:

sagemath/sagetrac-mirror@7dd85ff

sagemath/sagetrac-mirror@faad461

sagemath/sagetrac-mirror@78a4253

sagemath/sagetrac-mirror@ef1f3b7

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 12, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

f75e10dif w1 is a word, return a word, else a list
3f8f272added doc test, minor change for test of Composition, correct import
06fd19dMerge branch 'public/25018/bug_in_shuffle' of git://trac.sagemath.org/sage into public/combinat/extend_shuffle_product-15597
4252484Merge branch 'public/combinat/extend_shuffle_product-15597' of git://trac.sagemath.org/sage into public/combinat/implement_wqsym-25133
82240b2Fixing some details and making Symmetric capitalized in the name.
eb52ae3Merge branch 'public/combinat/implement_wqsym-25133' of trac.sagemath.org:sage into homs
2d6d158Merge branch 'public/combinat/wqsym_morphisms-25141' of trac.sagemath.org:sage into homs
70ccf5fchanges necessitated by renaming in #25133
98fca9cMerge branch 'public/combinat/fqsym2' of trac.sagemath.org:sage into homs

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 12, 2018

Changed commit from ef1f3b7 to 98fca9c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 12, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

416a8c0more corrections due to recent merge

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 12, 2018

Changed commit from 98fca9c to 416a8c0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 12, 2018

Changed commit from 416a8c0 to 6e40666

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 12, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

2dfbcacFixing issue with capitalization.
4f2ddfeMerge branch 'public/combinat/fqsym2' of git://trac.sagemath.org/sage into public/combinat/fqsym2
beeea6aAbstracting methods to DRY.
6e40666Calling the M basis the monomial basis.

@darijgr
Copy link
Contributor

darijgr commented Apr 12, 2018

Reviewer: Travis Scrimshaw

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 10, 2018

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. Last 10 new commits:

c8c6906Merge branch 'public/combinat/wqsym_morphisms-25141' of git://trac.sagemath.org/sage into public/combinat/wqsym_morphisms-25141
9d90234Initial additional of global options to WQSym
fd61441Added two global options for display of elements of WordQuasiSymmetricFunctions.
c828b0eSome reviewer changes.
ba70317A few more reviewer changes.
6e50492updated doc string for intended usage vis.a.vis packed words
27b9a98doctest and Travis' check
0efedd0Merge branch 'public/combinat/wqsym_options-25155' of git://trac.sagemath.org/sage into public/combinat/wqsym_morphisms-25141
728ff81Merge branch 'public/combinat/wqsym_morphisms-25141' of git://trac.sagemath.org/sage into public/combinat/wqsym_morphisms-25141
8dc0c5cMerge branch 'public/combinat/fqsym2' of git://trac.sagemath.org/sage into 25136

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 10, 2018

Changed commit from 6e40666 to 8dc0c5c

@sagetrac-git sagetrac-git mannequin removed the s: positive review label May 10, 2018
@sagetrac-git sagetrac-git mannequin added the s: needs review label May 10, 2018
@darijgr
Copy link
Contributor

darijgr commented May 10, 2018

comment:12

Trivial rebase over one of the dependencies.

@darijgr
Copy link
Contributor

darijgr commented May 15, 2018

comment:13

wake up patchbots

@darijgr darijgr modified the milestones: sage-8.2, sage-8.3 May 15, 2018
@darijgr
Copy link
Contributor

darijgr commented May 16, 2018

comment:14
File "src/sage/combinat/ncsym/bases.py", line 640, in sage.combinat.ncsym.bases.NCSymBases.ElementMethods.to_wqsym
Failed example:
    (4*p[[1,3],[2]]-p[[1]]).to_wqsym()
Expected:
    4*M[{1, 2, 3}] + 4*M[{2}, {1, 3}] + 4*M[{1, 3}, {2}] - M[{1}]
Got:
    4*M[{2}, {1, 3}] - M[{1}] + 4*M[{1, 2, 3}] + 4*M[{1, 3}, {2}]

Can't reproduce this one. But it's from a few versions ago, so maybe it's fixed now.

@darijgr
Copy link
Contributor

darijgr commented May 17, 2018

comment:15

The last patchbot is happy now, so I think this is ready to go.

@vbraun
Copy link
Member

vbraun commented May 22, 2018

Changed branch from public/combinat/fqsym2 to 8dc0c5c

@fchapoton
Copy link
Contributor

Changed commit from 8dc0c5c to none

@fchapoton
Copy link
Contributor

comment:17

FQSYM doctests now take way too long..

@darijgr
Copy link
Contributor

darijgr commented Jun 11, 2018

comment:18

Are they still taking too long if you pull #25326 as well? One of the things I did in #25326 was optimizing FQSym, particularly the M basis.

(NB: I don't know how long doctests should take on Cygwin, so I have no way to tell if I'm doing things right.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants