Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DESTDIR support for zlib #25142

Closed
embray opened this issue Apr 11, 2018 · 12 comments
Closed

Add DESTDIR support for zlib #25142

embray opened this issue Apr 11, 2018 · 12 comments
Labels
c: build p: major / 3 t: enhancement
Milestone
sage-8.4

Comments

@embray
Copy link
Contributor

embray commented Apr 11, 2018

Implements #24024 for zlib. This was actually rather straightforward--although zlib has a hand-written configure script, it seems to be fully compatible with one generated by autoconf.

Component: build

Keywords: destdir zlib

Author: Erik Bray

Branch/Commit: 847136b

Reviewer: Julian Rüth

Issue created by migration from https://trac.sagemath.org/ticket/25142
@embray embray added this to the sage-8.2 milestone Apr 11, 2018
@embray embray modified the milestones: sage-8.2, sage-8.3 Apr 26, 2018
@videlec
Copy link
Contributor

videlec commented May 12, 2018

comment:3

merge conflicts

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 14, 2018

Changed commit from 6fe90db to ba047f9

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 14, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ba047f9Add DESTDIR support for zlib

@embray
Copy link
Contributor Author

embray commented May 14, 2018

comment:5

Rebased since its dependency #23733 has been satisfied.

@embray
Copy link
Contributor Author

embray commented May 14, 2018

Changed dependencies from #23733 to none

@saraedum
Copy link
Member

comment:6

Looks good to me. Feel free to set to positive review if you are confident that this still works.

@saraedum
Copy link
Member

Reviewer: Julian Rüth

@embray
Copy link
Contributor Author

embray commented Jul 17, 2018

comment:7

I'm confident, but let me go ahead and rebase it.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 17, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

847136bAdd DESTDIR support for zlib

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 17, 2018

Changed commit from ba047f9 to 847136b

@embray
Copy link
Contributor Author

embray commented Jul 18, 2018

comment:10

I believe this issue can reasonably be addressed for Sage 8.4.

@embray embray modified the milestones: sage-8.3, sage-8.4 Jul 18, 2018
@vbraun
Copy link
Member

vbraun commented Aug 5, 2018

Changed branch from u/embray/build/destdir-zlib to 847136b

@vbraun vbraun closed this as completed in 1df416f Aug 5, 2018
@embray embray mentioned this issue Jan 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.4
Development

No branches or pull requests
4 participants
@saraedum @embray @vbraun @videlec