New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade cysignals to version 1.7.1 #25189
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
New commits:
|
Commit: |
This comment has been minimized.
This comment has been minimized.
comment:6
Thats not a supported platform -> next beta cycle |
comment:7
Replying to @vbraun:
What's your definition of "supported platform" and why does this system not satisfy? Previous versions of Sage worked perfectly with 100% doctests passing and I actually use this machine for serious stuff (i.e. it's not a museum machine that I only use to annoy release managers with bug reports). PS: I know that I've been messing up with cysignals breakage in this release cycle, but there is always some strange OS quirk that comes up. |
comment:8
Imho supported platform requires having a buildbot The 2 users of Sage on that arch can just follow the develop branch. We've seen how easy it is to break something by mucking with signal handlers in this release cycle, so I'm against last minute changes if they can be avoided |
comment:9
Replying to @vbraun:
That just means that we should put a buildbot on that machine. For a while now, I have a patchbot running there.
Can't argue with that I guess.
If it helps, there are no actual changes to signal handling, only to threading :-) |
Reviewer: Vincent Klein |
comment:11
All tests run for me. Let me know if you see more specific test to do. |
comment:13
@vbraun: can we at least make this a 8.3 blocker then, in the sense that it should be merged with priority in the 8.3 branch? |
Changed branch from u/jdemeyer/upgrade_cysignals_to_version_1_7_1 to |
Unfortunately, cysignals-1.7.0 is broken on ppc64le GNU/Linux.
Tarball: https://files.pythonhosted.org/packages/81/64/0959438193254c2c6ad127fb5f9aad4140bc4288d752d03b1976ef8366e0/cysignals-1.7.1.tar.gz
Component: packages: standard
Author: Jeroen Demeyer
Branch/Commit:
4ed886b
Reviewer: Vincent Klein
Issue created by migration from https://trac.sagemath.org/ticket/25189
The text was updated successfully, but these errors were encountered: