Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade cysignals to version 1.7.1 #25189

Closed
jdemeyer opened this issue Apr 17, 2018 · 14 comments
Closed

Upgrade cysignals to version 1.7.1 #25189

jdemeyer opened this issue Apr 17, 2018 · 14 comments

Comments

@jdemeyer
Copy link

Unfortunately, cysignals-1.7.0 is broken on ppc64le GNU/Linux.

Tarball: https://files.pythonhosted.org/packages/81/64/0959438193254c2c6ad127fb5f9aad4140bc4288d752d03b1976ef8366e0/cysignals-1.7.1.tar.gz

Component: packages: standard

Author: Jeroen Demeyer

Branch/Commit: 4ed886b

Reviewer: Vincent Klein

Issue created by migration from https://trac.sagemath.org/ticket/25189

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

@jdemeyer
Copy link
Author

New commits:

4ed886bUpgrade cysignals to version 1.7.1

@jdemeyer
Copy link
Author

Commit: 4ed886b

@jdemeyer

This comment has been minimized.

@vbraun
Copy link
Member

vbraun commented Apr 17, 2018

comment:6

Thats not a supported platform -> next beta cycle

@jdemeyer
Copy link
Author

comment:7

Replying to @vbraun:

Thats not a supported platform

What's your definition of "supported platform" and why does this system not satisfy?

Previous versions of Sage worked perfectly with 100% doctests passing and I actually use this machine for serious stuff (i.e. it's not a museum machine that I only use to annoy release managers with bug reports).

PS: I know that I've been messing up with cysignals breakage in this release cycle, but there is always some strange OS quirk that comes up.

@vbraun
Copy link
Member

vbraun commented Apr 17, 2018

comment:8

Imho supported platform requires having a buildbot

The 2 users of Sage on that arch can just follow the develop branch.

We've seen how easy it is to break something by mucking with signal handlers in this release cycle, so I'm against last minute changes if they can be avoided

@jdemeyer
Copy link
Author

comment:9

Replying to @vbraun:

Imho supported platform requires having a buildbot

That just means that we should put a buildbot on that machine. For a while now, I have a patchbot running there.

The 2 users of Sage on that arch can just follow the develop branch.

Can't argue with that I guess.

We've seen how easy it is to break something by mucking with signal handlers in this release cycle, so I'm against last minute changes if they can be avoided

If it helps, there are no actual changes to signal handling, only to threading :-)

@vinklein
Copy link
Mannequin

vinklein mannequin commented Apr 20, 2018

Reviewer: Vincent Klein

@vinklein
Copy link
Mannequin

vinklein mannequin commented Apr 20, 2018

comment:11

All tests run for me. Let me know if you see more specific test to do.

@jdemeyer
Copy link
Author

comment:13

@vbraun: can we at least make this a 8.3 blocker then, in the sense that it should be merged with priority in the 8.3 branch?

@vbraun
Copy link
Member

vbraun commented May 8, 2018

Changed branch from u/jdemeyer/upgrade_cysignals_to_version_1_7_1 to 4ed886b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants