New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve handling of GCC_DEP variable in Makefile #25198
Comments
Dependencies: #25188 |
Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:
|
comment:4
I believe this issue can reasonably be addressed for Sage 8.4. |
Reviewer: Dima Pasechnik |
comment:7
Needs rebasing. |
comment:8
(automatically) rebased. |
Changed branch from u/embray/build/ticket-25188-2 to public/build/ticket-25188-2 |
comment:9
I was lead here because Volker selected this ticket for inclusion in his merging branch and when I looked on github to see the content of the commit, it came empty. vbraun@0c158ca Then clicking here resulted in a failure to merge. So Volker will need to re-merge this one now. Ping @vbraun the content of this ticket is currently missing in the merge. |
Changed commit from |
Changed branch from public/build/ticket-25188-2 to none |
comment:10
(Edited, because I was mistaken slightly about the relation of this ticket to #24919.) This doesn't seem right. This branch just looks identical to the one on #25857 now. These changes are already included implicitly in #24919 which is positively reviewed and should be merged. The reason this is confusing is that I worked on this ticket at the same time as #24919, but #24919 redid a lot of configure stuff so it included those changes by necessity. If we just merge #24919, this ticket can be closed as fixed. |
comment:11
I take it back. Apparently I'm wrong. #24919 does not incorporate all elements of this ticket. Apparently at some point I decoupled them somewhat. I'll create a new branch... |
comment:12
Okay, apparently I ended up rolling this back into #25188, hence the empty merge. |
This is a followup to #25188 that I thought was worth doing while fixing that issue. However, since it's not strictly needed for the fix I'll make it a separate ticket.
Depends on #25188
CC: @vbraun
Component: build
Author: Erik Bray
Reviewer: Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/25198
The text was updated successfully, but these errors were encountered: