py3: miscellaneous minor fixes to sage.crypto

[embray]

Component: python3

Author: Erik Bray

Branch: aae8c92

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/25231

[sagetrac-git]

Commit: 15b7144

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

5dfe379	py3: more bytes->str fixes in sage.rings.polynomial.pbori
20f0c47	py3: minor test fixes in sage.rings.polynomial.pbori
15b7144	whitespace fix

[embray]

comment:2

Oops, totally mixed this up with another branch somehow.

[sagetrac-git]

Changed commit from 15b7144 to ed88620

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

c284d77	py3: fix some map() calls that don't work (refs #16073)
4de2b4d	py3: use sage_getargspec instead of plain inspect.getargspec
ed88620	py3: minor test fix to account for tiny difference in exception message formatting

[fchapoton]

comment:5

The change to src/sage/rings/polynomial/pbori.pyx seems not necessary. Cython knows about that, I have been told. But maybe I am wrong.

Otherwise, looks good to me

[embray]

comment:6

Oh, the problem there is that it only works in Cython if the underlying object is actually a dict. It doesn't work, annoyingly, if it's not exactly a dict. That said, I had intended to undo that change--the object in question here was a KeyConvertingDict. But the better approach I found for this is to just add iterkeys/itervalues/iteritems methods on KeyConvertingDict for backwards compatibility.

[embray]

comment:7

That change wasn't even supposed to be in this ticket. I'm not sure how it's still there.

[sagetrac-git]

Changed commit from ed88620 to aae8c92

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

d52895c	py3: fix some map() calls that don't work (refs #16073)
b74a4d0	py3: use sage_getargspec instead of plain inspect.getargspec
aae8c92	py3: minor test fix to account for tiny difference in exception message formatting

[fchapoton]

Reviewer: Frédéric Chapoton

[fchapoton]

comment:9

ok

[vbraun]

Changed branch from u/embray/python3/sage-crypto/misc to aae8c92

[jhpalmieri]

Changed branch from aae8c92 to u/jhpalmieri/aae8c920192bc18c845edbd02fec770132cc97c0

[jhpalmieri]

Changed commit from aae8c92 to none

[jhpalmieri]

Changed branch from u/jhpalmieri/aae8c920192bc18c845edbd02fec770132cc97c0 to aae8c92

[jhpalmieri]

comment:12

Sorry, wrong ticket.