Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: remove has_key in padics #25280

Closed
fchapoton opened this issue May 2, 2018 · 6 comments
Closed

py3: remove has_key in padics #25280

fchapoton opened this issue May 2, 2018 · 6 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.3

Comments

@fchapoton
Copy link
Contributor

CC: @xcaruso

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 1631482

Reviewer: David Roe

Issue created by migration from https://trac.sagemath.org/ticket/25280
@fchapoton fchapoton added this to the sage-8.3 milestone May 2, 2018
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/25280

@fchapoton
Copy link
Contributor Author

Commit: 1631482

@fchapoton
Copy link
Contributor Author

New commits:

1631482fixing some py3-compatibility issues in padics (has_key is deprecated)

@roed314
Copy link
Contributor

roed314 commented May 2, 2018

comment:2

Looks good.

@roed314
Copy link
Contributor

roed314 commented May 2, 2018

Reviewer: David Roe

@vbraun
Copy link
Member

vbraun commented May 15, 2018

Changed branch from u/chapoton/25280 to 1631482

@vbraun vbraun closed this as completed in 7a76bb2 May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.3
Development

No branches or pull requests
3 participants
@roed314 @vbraun @fchapoton