New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Cython 0.29.1 #25292
Comments
comment:1
update milestone 8.3 -> 8.4 |
This comment has been minimized.
This comment has been minimized.
Author: Jeroen Demeyer |
Dependencies: #26396 |
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. New commits:
|
Commit: |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:13
Attachment: cython-0.29.log Running (The two failing tests in #26450 don't seem to be an issue anymore in 0.29.) |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Upstream: Fixed upstream, but not in a stable release. |
comment:16
Replying to @Konrad127123:
Fixed by cython/cython#2674 |
Changed dependencies from #26396 to none |
comment:18
Replying to @jdemeyer:
I can confirm that cython now builds with |
comment:19
Can somebody review this please? There are follow-up tickets depending on this one. |
comment:20
Does this mean Cython 0.29 will become a hard dependency of Sage? I don't mind that ofc, but maybe the tickets that depend on it can be done in such a way that checks this (e.g., checks the Cython version before enabling those features). I'm going to give this a quick check on Cygwin, but I doubt there will be any problem, so positive_review from me if it that works. |
comment:29
For what its worth, here is the status of cython on various distros and these are the distros that package sage. Debian Unstable hasn't upgraded yet. Arch and Nix have. Gentoo isn't listed for some reason. |
comment:30
Replying to @timokau:
Gentoo main tree, doesn't have it yet. But the sage-on-gentoo repo does have a package ready for when this ticket makes it regardless of the main tree. |
comment:31
Note that Cython 0.29.1 has now been released. |
comment:32
Actually the Gentoo main tree caught up to me yesterday and 0.29.1 is in the main tree. |
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
comment:35
Not tested yet... |
comment:36
Replying to @timokau:
That's a cool site--I was not aware of it before. It doesn't look like it tracks conda-forge or cygwin packages either. I wonder how hard it would be to add trackers for new repositories to the site... |
comment:37
Replying to @embray:
Yeah its pretty neat. Nix uses a bot that automatically generates trivial package update PRs based on repology data. I think adding support for another repo would basically sonsist of (1) finding a relibale data source that gives current metadata about all packages and (2) converting that datasource into the format repology expects. There are already issues for conda-forge and cygwin. |
comment:38
Replying to @jdemeyer:
Back to topic: So in its current state this ticket is not backwards compatible? |
comment:39
Replying to @timokau:
The curating is imperfect and for some distros it is listed under "cython" and for other under "python:cython" https://repology.org/metapackage/python:cython/versions not much you can do about that. |
comment:40
You can report it (I just did). Every time I've done that it has been resolved within a couple of hours. |
comment:41
Replying to @timokau:
No, it is not. The difference is really small though, packagers that insist on Cython 0.28 can easily revert this patch. |
comment:42
Okay since the majority have already switched (all but debian I think) and its very possible that debian will have switched by the time 8.5 is released, I think we can go forward. Any other opinions? |
comment:43
Replying to @jdemeyer:
I think that's a bit presumptuous. But I agree there's no reason for anyone to hold back up on updating Cython and that it should/will happen before long so I don't object to moving forward on this. |
Reviewer: Timo Kaufmann |
Changed branch from u/jdemeyer/upgrade_to_cython_0_29 to |
Tarball: https://files.pythonhosted.org/packages/f0/f8/7f406aac4c6919d5a4ce16509bbe059cd256e9ad94bae5ccac14094b7c51/Cython-0.29.1.tar.gz
Follow-up tickets:
Upstream: Fixed upstream, but not in a stable release.
CC: @kiwifb @embray @saraedum
Component: packages: standard
Author: Jeroen Demeyer
Branch/Commit:
4c3e314
Reviewer: Timo Kaufmann
Issue created by migration from https://trac.sagemath.org/ticket/25292
The text was updated successfully, but these errors were encountered: