some care for magma interface

[fchapoton]

because parts of it are broken for magma V2.22

and also enhance its treatment of matrices.

CC: @loefflerd

Component: interfaces

Keywords: magma

Author: Frédéric Chapoton

Branch/Commit: ba69135

Reviewer: David Loeffler

Issue created by migration from https://trac.sagemath.org/ticket/25306

[fchapoton]

Branch: u/chapoton/25306

[fchapoton]

New commits:

5e52902

trying to fix magma interface, and enhance it for matrices

[fchapoton]

Commit: 5e52902

[fchapoton]

Changed keywords from none to magma

[loefflerd]

comment:5

I tested it against Magma v2.23-8 but many doctests failed. I have opened #25408 for this issue, where there are 12 failures listed; 8 of them still fail with this patch installed.

[sagetrac-git]

Changed commit from 5e52902 to 950d325

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

bdf0508	Merge branch 'u/chapoton/25306 in 8.3.b2
950d325	fix one doctest (change of point found on conic)

[fchapoton]

comment:7

Could we agree to use this as a first step ? I would like to have the matrix enhancements at my disposal.

[loefflerd]

Changed branch from u/chapoton/25306 to u/davidloeffler/25306

[loefflerd]

comment:9

OK, I see your point. The perfect is the enemy of the good, as the saying goes. I pushed a patch which fixes a couple more doctests that were failing (no code changes) -- if you're happy with that then please set the ticket to positive review.

---

New commits:

9b42b5a

Fix a couple more failing doctests

[loefflerd]

Changed commit from 950d325 to 9b42b5a

[fchapoton]

comment:10

thanks. good for me. Note that the Kronecker representation seems to have changed betwen my version of m*gma and yours..

[fchapoton]

Reviewer: David Loeffler

[vbraun]

comment:11

sage -t --long src/sage/interfaces/magma.py
**********************************************************************
File "src/sage/interfaces/magma.py", line 2088, in sage.interfaces.magma.MagmaElement.AssignNames
Failed example:
    S.1^2 + S.2
Exception raised:
    Traceback (most recent call last):
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 572, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/mnt/disk/home/release/Sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 982, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.interfaces.magma.MagmaElement.AssignNames[0]>", line 1, in <module>
        S.gen(1)**Integer(2) + S.gen(2)
    NameError: name 'S' is not defined
**********************************************************************
1 item had failures:
   1 of   2 in sage.interfaces.magma.MagmaElement.AssignNames
    [84 tests, 1 failure, 0.77 s]

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

ba69135

Trac #25306: missing #optional flag on doctest

[sagetrac-git]

Changed commit from 9b42b5a to ba69135

[loefflerd]

comment:13

Oops, I forgot to flag this doctest as #optional-magma.

[vbraun]

Changed branch from u/davidloeffler/25306 to ba69135