Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support GiNaC's patternless substitution #25307

Closed
rwst opened this issue May 8, 2018 · 5 comments
Closed

Support GiNaC's patternless substitution #25307

rwst opened this issue May 8, 2018 · 5 comments
Labels
c: symbolics r: invalid t: enhancement

Comments

@rwst
Copy link

rwst commented May 8, 2018

Intuitively substitution should replace wildcards in the source expression but this is a separate case in GiNaC. Powers and functions are affected:

sage: w=SR.wild(1)
sage: (w^2).subs(w==x)
x
sage: polylog(w,2).subs(w==x)
x

GiNaC provides for several flags that can be set with the call to subs(), but Expression.subs() only sends a zero now. In this case GiNaC::subs_options::no_pattern = 0x0001 would be needed.

Component: symbolics

Issue created by migration from https://trac.sagemath.org/ticket/25307
@rwst rwst added this to the sage-8.3 milestone May 8, 2018
@rwst

This comment has been minimized.

Sign in to view
@rwst rwst changed the title Wildcard power substitution broken Wildcard substitution broken May 9, 2018
@rwst

This comment has been minimized.

Sign in to view
@rwst rwst changed the title Wildcard substitution broken Support GiNaC's patternless substitution May 9, 2018
@rwst
Copy link
Author

rwst commented May 27, 2018

comment:3

Duplicate, sorry.

@rwst rwst removed this from the sage-8.3 milestone May 27, 2018
@rwst
Copy link
Author

rwst commented May 27, 2018

comment:5

#25447

@embray
Copy link
Contributor

embray commented Feb 26, 2019

comment:6

Presuming these are all correctly reviewed as either duplicate, invalid, or wontfix.

@embray embray closed this as completed Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: symbolics r: invalid t: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@embray @rwst