Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

padic bugfix #2532

Closed
roed314 opened this issue Mar 15, 2008 · 7 comments
Closed

padic bugfix #2532

roed314 opened this issue Mar 15, 2008 · 7 comments
Assignees
@roed314
Labels
c: basic arithmetic p: major / 3 t: bug
Milestone
sage-2.10.4

Comments

@roed314
Copy link
Contributor

roed314 commented Mar 15, 2008

Fixes a number of bugs in p-adic extensions.

  • changes many object creation functions to pass on exceptions if necessary.
  • fixes a bug in precision_absolute for capped relative extension elements that causes it to return the wrong answer if the element is not normalized.
  • Fixes object creation functions so that they do not fail when asked to create an element of precision zero.

Component: basic arithmetic

Issue created by migration from https://trac.sagemath.org/ticket/2532
@roed314 roed314 added this to the sage-2.11 milestone Mar 15, 2008
@roed314 roed314 self-assigned this Mar 15, 2008
@mwhansen
Copy link
Contributor

comment:1

Attachment: padic_restore_context_zero_bugfix.patch.gz

@mwhansen mwhansen changed the title [with-patch] padic bugfix padic bugfix Mar 15, 2008
@sagetrac-mabshoff

This comment has been minimized.

Sign in to view
@mwhansen
Copy link
Contributor

comment:3

The patch applies, builds, and passes all tests. However, a follow-up patch should be added which adds doctests to show that the bugs are indeed fixed.

@mwhansen mwhansen changed the title padic bugfix [positive review pending changes] padic bugfix Mar 15, 2008
@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Mar 17, 2008

comment:4

Doctests also pass for me when applying the patch to 2.10.4.final. After talking to roed about the missing doctest in IRC yesterday I tend to want to merge this and hope that doctests are forthcomings since these fixes have been tested and reviewed by several people "back east."

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin modified the milestones: sage-2.11, sage-2.10.4 Mar 17, 2008
@sagetrac-dmharvey
Copy link
Mannequin

sagetrac-dmharvey mannequin commented Mar 17, 2008

comment:5

I agree. Given the current doctest coverage and code complexity of the p-adics code, I think we should just merge this and wait for the real doctesting work to catch up.

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Mar 17, 2008

comment:6

I agree with dmharvey. #610 covers the need to increase doctest coverage. Maybe somebody else besides roed can help out here?

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin changed the title [positive review pending changes] padic bugfix padic bugfix Mar 17, 2008
@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Mar 17, 2008

comment:7

Merged in Sage 2.10.4.final - note that the patch is a GNU patch. I did commit it in roed's name.

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Mar 17, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roed314 roed314

Labels
c: basic arithmetic p: major / 3 t: bug
Projects
None yet
Milestone
sage-2.10.4
Development

No branches or pull requests
2 participants
@roed314 @mwhansen