Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature check for benzene is broken #25325

Closed
antonio-rojas opened this issue May 10, 2018 · 8 comments
Closed

Feature check for benzene is broken #25325

antonio-rojas opened this issue May 10, 2018 · 8 comments
Labels
c: packages: optional p: blocker / 1 t: bug
Milestone
sage-8.3

Comments

@antonio-rojas
Copy link
Contributor

There is a mistake in the Benzene Features test: it should test for the ">>planar_code<<" string, not for ">>planar_graph<<". As it is now, the test always fails.

CC: @kiwifb

Component: packages: optional

Author: Vincent Delecroix

Branch/Commit: 8b0adb8

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/25325
@antonio-rojas antonio-rojas added this to the sage-8.3 milestone May 10, 2018
@antonio-rojas antonio-rojas changed the title Typo in benzene Features check Several issues with Features May 10, 2018
@jdemeyer jdemeyer changed the title Several issues with Features Feature check for benzene is broken May 10, 2018
@jdemeyer
Copy link

comment:6

I created #25334 for CSDP and #25333 for plantri.

@videlec
Copy link
Contributor

videlec commented May 13, 2018

Branch: u/vdelecroix/25325

@videlec
Copy link
Contributor

videlec commented May 13, 2018

Commit: 8b0adb8

@videlec
Copy link
Contributor

videlec commented May 13, 2018

Author: Vincent Delecroix

@videlec
Copy link
Contributor

videlec commented May 13, 2018

New commits:

8b0adb825325: fix benzene feature

@tscrim
Copy link
Collaborator

tscrim commented May 13, 2018

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented May 13, 2018

comment:8

LGTM.

@vbraun
Copy link
Member

vbraun commented May 15, 2018

Changed branch from u/vdelecroix/25325 to 8b0adb8

@vbraun vbraun closed this as completed in e59ca0b May 15, 2018
@videlec videlec mentioned this issue Jun 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: optional p: blocker / 1 t: bug
Projects
None yet
Milestone
sage-8.3
Development

No branches or pull requests
5 participants
@vbraun @tscrim @jdemeyer @videlec @antonio-rojas