Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't check for the exact glpk version #25329

Closed
timokau opened this issue May 10, 2018 · 4 comments
Closed

Don't check for the exact glpk version #25329

timokau opened this issue May 10, 2018 · 4 comments
Labels
c: distribution p: major / 3 t: enhancement
Milestone
sage-8.3

Comments

@timokau
Copy link
Contributor

timokau commented May 10, 2018

Independent of #24824, sage shouldn't check for the exact glpk version in the doctests.

I'm using sage with glpk 4.65 with the debian patch to ignore the warnings for now and noticed that this doctest checks for glpk 4.63.

Component: distribution

Author: Timo Kaufmann

Branch/Commit: 89d068d

Reviewer: Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/25329
@timokau timokau added this to the sage-8.3 milestone May 10, 2018
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 13, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

89d068dDon't check for the exact glpk version

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 13, 2018

Changed commit from 70ebe92 to 89d068d

@videlec
Copy link
Contributor

videlec commented May 13, 2018

Reviewer: Vincent Delecroix

@vbraun
Copy link
Member

vbraun commented May 15, 2018

Changed branch from u/gh-timokau/glpk-version-check to 89d068d

@vbraun vbraun closed this as completed in cc51e6f May 15, 2018
@timokau timokau mentioned this issue May 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: distribution p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.3
Development

No branches or pull requests
3 participants
@vbraun @timokau @videlec