Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade maxima to 5.41.0 #25355

Closed
timokau opened this issue May 13, 2018 · 19 comments
Closed

Upgrade maxima to 5.41.0 #25355

timokau opened this issue May 13, 2018 · 19 comments

Comments

@timokau
Copy link
Contributor

timokau commented May 13, 2018

This upgrades maxima to 5.41.0, available at

https://netcologne.dl.sourceforge.net/project/maxima/Maxima-source/5.41.0-source/maxima-5.41.0.tar.gz

The doctest changes are just different ways to write the same results, no semantics changed.

CC: @kiwifb @embray

Component: packages: standard

Keywords: upgrade

Author: Timo Kaufmann

Branch: 16c2409

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/25355

@timokau timokau added this to the sage-8.3 milestone May 13, 2018
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 13, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

7df6d82Upgrade maxima to 5.41.0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 13, 2018

Changed commit from b2b689b to 7df6d82

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link

comment:6

If you want to run a test but ignore its output, use # random instead of # not tested.

For example, we do want to test that maxima.version() works (i.e. it does not raise an exception).

@jdemeyer

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 14, 2018

Changed commit from 7df6d82 to 16c2409

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 14, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

16c2409Upgrade maxima to 5.41.0

@timokau

This comment has been minimized.

@timokau
Copy link
Contributor Author

timokau commented May 14, 2018

comment:9

Good point, changed.


New commits:

16c2409Upgrade maxima to 5.41.0

@jdemeyer
Copy link

Reviewer: Jeroen Demeyer

@jdemeyer
Copy link

comment:10

Why did you change back the download link? A direct link is easiest for the release manager.

@timokau

This comment has been minimized.

@timokau
Copy link
Contributor Author

timokau commented May 14, 2018

comment:11

That was by mistake, I must've hit the reverse button or something.

@vbraun
Copy link
Member

vbraun commented May 15, 2018

Changed branch from u/gh-timokau/maxima-5.41.0 to 16c2409

@fchapoton
Copy link
Contributor

comment:13

This update may have broken sage-python3, which does no longer start anymore...

    575         self._prompt_wait = ([self._prompt.encode('ascii')] +
--> 576                              [re.compile(x) for x in self._ask] +
        global re.compile = <function compile at 0x7f7eb678c8c8>
        global x = undefined
        self._ask = [b'zero or nonzero\\?', b'an integer\\?', b'positive, negat\
ive or zero\\?', b'positive or negative\\?', b'positive or zero\\?', b'equal to\
 .*\\?']
    577                              [b'Break [0-9]+'])  # note that you might \
need to change _expect_expr if you
    578                                                  # change this
    579         self._error_re = re.compile('(Principal Value|debugmode|incorre\
ct syntax|Maxima encountered a Lisp error)')
    580         self._display2d = False
    581
    582     def set_seed(self, seed=None):
    583         """
    584         http://maxima.sourceforge.net/docs/manual/maxima_10.html
    585         make_random_state (n) returns a new random state object created\
 from an
    586         integer seed value equal to n modulo 2^32. n may be negative.
    587
    588         EXAMPLES::
    589
    590             sage: m = Maxima()
...
AttributeError: 'bytes' object has no attribute 'encode'

@fchapoton
Copy link
Contributor

Changed commit from 16c2409 to none

@embray
Copy link
Contributor

embray commented May 21, 2018

comment:14

Hmm, I don't think this is what did it. Probably more likely one of my patches--probably one of the older ones that only recently got merged, and actually didn't work with some more recent patches.

@fchapoton
Copy link
Contributor

comment:15

Yes, you are right. This should be fixed by #24269, which needs some care.

@embray
Copy link
Contributor

embray commented May 21, 2018

comment:16

Ah, #24269 is one of the tickets I was thinking might have caused the breakage. I thought it was already merged recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants