Support for binary quintics in invariant_theory

[jnoordsij]

This ticket implements the option to create binary quintics within the invariant_theory framework as well as its invariants and covariants as described in 'Theorie der binären algebraischen formen' by Clebsch.

CC: @mstreng @pjbruin

Component: algebra

Keywords: invariant_theory

Author: Jesper Noordsij

Branch/Commit: 2ee55b5

Reviewer: Frédéric Chapoton, Marco Streng

Issue created by migration from https://trac.sagemath.org/ticket/25395

[jnoordsij]

Branch: u/jnoordsij/binary_quintics

[jnoordsij]

New commits:

6edff6e

Added binary quintics to invariant_theory.

[jnoordsij]

Commit: 6edff6e

[sagetrac-git]

Changed commit from 6edff6e to 78a30ed

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

796ea1b	Merge branch 'develop' into t/25395/binary_quintics
78a30ed	Adjusted to fix slower startup time.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

b935917

Merge branch 'develop' into t/25395/binary_quintics

[sagetrac-git]

Changed commit from 78a30ed to b935917

[fchapoton]

comment:5

• + Returns the h-th transvectant of f and g.
  should be
  + Return the h-th transvectant of f and g.
  And same thing (Return) for all first lines of all functions and methods.

• EXAMPLES:: is mis-indented in transvectant

• references should look like [Cle1872]_ not like _[Cle1872]

• TESTS:: and EXAMPLES:: must be followed by an empty line

• missing backquotes in + The \tau-covariant of the binary quintic as polynomial or as binary form.

etc, etc. Please thoroughly check the documentation of your work.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

dc81ba3	Documentation fixes.
385de7d	Merge branch 'develop' into t/25395/binary_quintics
e9d3bf0	Documentation fixes & transvectant adjustment.

[sagetrac-git]

Changed commit from b935917 to e9d3bf0

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

9ba8f5e

Minor documentation fixes.

[sagetrac-git]

Changed commit from e9d3bf0 to 9ba8f5e

[fchapoton]

comment:8

please now take care of the pyflakes plugin warnings, and fix the failing doctest (missing import)

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

48c7fca

Fixed pyflakes.

[sagetrac-git]

Changed commit from 9ba8f5e to 48c7fca

[sagetrac-git]

Changed commit from 48c7fca to 0423f81

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

0423f81

Removed canonical form to fix doctest.

[jnoordsij]

comment:11

Replying to @fchapoton:

please now take care of the pyflakes plugin warnings, and fix the failing doctest (missing import)

Thanks for looking into all this. The doctests should all be fine now and the pyflakes fixed.

---

New commits:

0423f81

Removed canonical form to fix doctest.

[mstreng]

Reviewer: Frédéric Chapoton, Marco Streng

[mstreng]

comment:12

Comments on code and documentation given to the author in personal communication.

[sagetrac-git]

Changed commit from 0423f81 to 626d1ed

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

c7e9db8	Moved an import
626d1ed	Documentation fixes based on reviewers comments.

[sagetrac-git]

Changed commit from 626d1ed to 13202e5

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

13202e5

Minor documentation fixes.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

c1b7a69

Documentation fixes.

[sagetrac-git]

Changed commit from 13202e5 to c1b7a69

[sagetrac-git]

Changed commit from c1b7a69 to 2d53868

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

2d53868

Documentation fixes and bugfix with homogenisation and transvectant.

[sagetrac-git]

Changed commit from 2d53868 to a4c7b97

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

a4c7b97

Documentation fix.

[sagetrac-git]

Changed commit from a4c7b97 to 2ee55b5

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

2ee55b5

Adjustment to AlgebraicForm string representation.

[mstreng]

comment:21

Positive review: Does what it says in the ticket description. Everything I tried works, except some things that already fail for existing cases (like quartic forms), which are results deeper bugs and should be fixed in a separate ticket. Nothing I tried gives incorrect results as far as I can see. Documentation looks good. Patchbot says all tests pass except some optional magma doctests that are unrelated to the ticket and that apparently fail on other tickets as well.

[vbraun]

Changed branch from u/jnoordsij/binary_quintics to 2ee55b5