New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LattE: is_package_installed -> feature #25400
Comments
This comment has been minimized.
This comment has been minimized.
Commit: |
Branch: u/vdelecroix/25400 |
Author: Vincent Delecroix |
comment:6
The function
Instead of reimporting it, we rather rely on the new feature framework introduced in #20382. |
Reviewer: Julian Rüth |
Work Issues: minimal documentation changes, make the patchbot happy |
comment:7
Looks good. I think you want to drop an "s" and replace The patchbot run looks weird. Do you understand what's going on? |
comment:8
This is a reasonable failure that has to be fixed
|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
comment:11
rebased on beta3... needs review |
Changed work issues from minimal documentation changes, make the patchbot happy to none |
comment:13
There's something about this ticket which seems to make patchbots crash. Whenever my patchbot (fermat) gets around to testing this ticket, it gets as far as applying the patch + building docs, and then it hangs -- the python subprocesses that are spawned to build the various ref manual chapters somehow get stuck + don't terminate. Any idea what could be causing this? No other currently-open ticket causes this behaviour. |
comment:14
I made a check at import time... if it fails it is possible that sphinx hang forever. I will test. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:17
feel free to set this to positive review if the patchbot issue is fixed now. |
Changed branch from u/vdelecroix/25400 to |
The function
_volume_latte
callsis_package_installed
which does not exist anymore. As a consequenceCC: @jplab @mkoeppe @mo271
Component: packages: optional
Author: Vincent Delecroix
Branch/Commit:
e54f09e
Reviewer: Julian Rüth
Issue created by migration from https://trac.sagemath.org/ticket/25400
The text was updated successfully, but these errors were encountered: