Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyflakes cleanup in databases, monoids and sets #25411

Closed
fchapoton opened this issue May 20, 2018 · 8 comments
Closed

pyflakes cleanup in databases, monoids and sets #25411

fchapoton opened this issue May 20, 2018 · 8 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-8.3

Comments

@fchapoton
Copy link
Contributor

Component: refactoring

Author: Frédéric Chapoton

Branch/Commit: 0fe4957

Reviewer: Martin Rubey, Julian Rüth

Issue created by migration from https://trac.sagemath.org/ticket/25411
@fchapoton fchapoton added this to the sage-8.3 milestone May 20, 2018
@fchapoton
Copy link
Contributor Author

Branch: public/25411

@fchapoton
Copy link
Contributor Author

Commit: 0fe4957

@fchapoton
Copy link
Contributor Author

New commits:

0fe4957pyflakes cleanup in databases, monoids and sets

@mantepse
Copy link
Contributor

comment:2

positive review for the findstat part (the richchmp typo is a good reason to run pyflakes, by the way). Many thanks!

@saraedum
Copy link
Member

Reviewer: Martin Rubey, Julian Rüth

@saraedum
Copy link
Member

comment:3

Looks good. Feel free to set this to positive review if the patchbot is happy.

@fchapoton
Copy link
Contributor Author

comment:4

thanks, setting to positive

@vbraun
Copy link
Member

vbraun commented May 24, 2018

Changed branch from public/25411 to 0fe4957

@vbraun vbraun closed this as completed in d8d3aa9 May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-8.3
Development

No branches or pull requests
4 participants
@saraedum @vbraun @fchapoton @mantepse