Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement right_kernel() and right_nullity() for matrices #2542

Closed
aghitza opened this issue Mar 16, 2008 · 5 comments
Closed

implement right_kernel() and right_nullity() for matrices #2542

aghitza opened this issue Mar 16, 2008 · 5 comments

Comments

@aghitza
Copy link

aghitza commented Mar 16, 2008

I implemented right_kernel() and right_nullity() for matrices in the simplest possible way (calling the left_ functions on the transpose of self). This is a tiny little step in the direction of #1607.

Component: linear algebra

Issue created by migration from https://trac.sagemath.org/ticket/2542

@mwhansen
Copy link
Contributor

Attachment: right_kernel.patch.gz

Attachment: 2542-2.patch.gz

@mwhansen
Copy link
Contributor

comment:1

Looks good to me. Apply 2542-2.patch which is rebased against 2.10.4.alpha0.

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Mar 16, 2008

comment:2

This patch causes a doctest failure for me:

sage -t -long devel/sage/sage/matrix/matrix2.pyx
**********************************************************************
File "matrix2.pyx", line 1170:
    sage: A.right_nullity()
Expected:
    1
Got:
    0
**********************************************************************
1 items had failures:
   1 of   4 in __main__.example_26
***Test Failed*** 1 failures.
For whitespace errors, see the file .doctest_matrix2.pyx

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin changed the title implement right_kernel() and right_nullity() for matrices [pending doctest fix] implement right_kernel() and right_nullity() for matrices Mar 16, 2008
@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Mar 16, 2008

comment:3
[06:34] <mhansen> mabshoff: For 2542, the doctest is wrong and the answer returned is correct.

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin changed the title [pending doctest fix] implement right_kernel() and right_nullity() for matrices implement right_kernel() and right_nullity() for matrices Mar 16, 2008
@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Mar 16, 2008

comment:4

Merged 2542-2.patch with corrected doctest in Sage 2.10.4.rc0

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Mar 16, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants