Allow more substitutions for non-classical rational function field valuations

[saraedum]

See MCLF/mclf#39 for a motivation of this.

CC: @sagetrac-swewers

Component: number theory

Author: Julian Rüth

Branch/Commit: 1607493

Reviewer: Stefan Wewers

Issue created by migration from https://trac.sagemath.org/ticket/25441

[saraedum]

Branch: u/saraedum/25441

[saraedum]

comment:2

I just disabled the safeguards that I had certainly put there for good reasons. I could imagine that without these I'd need more logic to fix things related to comparison and equality of valuations.

---

New commits:

94cd188

Drop the limitation on automorphisms of non-classical function field valuations

[saraedum]

Commit: 94cd188

[sagetrac-git]

Changed commit from 94cd188 to 2a93f94

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

2a93f94

Merge remote-tracking branch 'trac/develop' into 25441

[saraedum]

comment:4

I'll monkey patch this in MCLF for MCLF/mclf#39 so swewers can play with this and see whether this actually works.

[saraedum]

comment:5

swewers: Does this change seem to work? If so, I'd prepare it for actual inclusion in Sage.

[saraedum]

Work Issues: merge in develop to make build pass

[sagetrac-swewers]

comment:6

Yes, the code in https://github.com/MCLF/mclf/tree/develop uses this change, and it seems to work.

[sagetrac-git]

Changed commit from 2a93f94 to e9505c9

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

c7741b4	Merge branch '25441' into HEAD
e9505c9	Add tests for 94cd188

[saraedum]

Changed work issues from merge in develop to make build pass to is the patchbot happy?

[saraedum]

New commits:

c7741b4	Merge branch '25441' into HEAD
e9505c9	Add tests for 94cd188

[saraedum]

Changed work issues from is the patchbot happy? to none

[saraedum]

comment:9

The failed plugins seem to be noise.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

c31eb21

Merge branch '25441' into HEAD

[sagetrac-git]

Changed commit from e9505c9 to c31eb21

[saraedum]

comment:11

swewers: Do you think you could review this one?

---

New commits:

c31eb21

Merge branch '25441' into HEAD

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

1607493

Merge develop and 25441

[sagetrac-git]

Changed commit from c31eb21 to 1607493

[sagetrac-swewers]

comment:13

This works as it should. Thanks.

[tscrim]

comment:14

Real name needed in the reviewers section.

[sagetrac-swewers]

Reviewer: Stefan Wewers

[sagetrac-swewers]

comment:15

Sure. Sorry for this.

[vbraun]

Changed branch from u/saraedum/25441 to 1607493