Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub templates #25468

Closed
saraedum opened this issue May 30, 2018 · 12 comments
Closed

GitHub templates #25468

saraedum opened this issue May 30, 2018 · 12 comments

Comments

@saraedum
Copy link
Member

This adds templates when people create Issues & PRs on GitHub (telling them not to do so.) In the long run it would be great to support this somehow but as long as we don't have that in place it's better to reduce frustration on both sides.

CC: @embray @roed314

Component: website/wiki

Author: Julian Rüth

Branch: 1cd567e

Reviewer: Erik Bray

Issue created by migration from https://trac.sagemath.org/ticket/25468

@saraedum saraedum added this to the sage-8.3 milestone May 30, 2018
@saraedum
Copy link
Member Author

Branch: u/saraedum/25468

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 30, 2018

Commit: 8b3afe0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 30, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

8b3afe0Fix grammar

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 30, 2018

Changed commit from 8b3afe0 to 1cd567e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 30, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

1cd567eHTTPS everywhere

@saraedum
Copy link
Member Author

comment:5

embray: Would you mind dropping the somewhat unfriendly "NO PRs" from our github page then? (While you're at it, could you change Sage's URL to use https?)

@embray
Copy link
Contributor

embray commented May 31, 2018

comment:6

I'm not sure about the use of "yet". Will we ever accept PRs on GitHub? :) I thought we were just going to on GitLab. Either way I'm fine with leaving the possibility open. And will do re: the changes on GH.

@embray
Copy link
Contributor

embray commented May 31, 2018

Reviewer: Erik Bray

@saraedum
Copy link
Member Author

comment:7

Great, thanks. Yes, I thought it's more welcoming if I make it sound like it's something that we'd like to have. I wouldn't mind accepting PRs on GitHub but I don't want to maintain the necessary infrastructure and if I had to choose, I'd prefer MRs on GitLab.

Btw, could you also disable the Wiki & Projects on our GitHub page? We might want to leave the issues tab active so people get to see the message that redirects them to trac?

@vbraun
Copy link
Member

vbraun commented Jun 1, 2018

Changed branch from u/saraedum/25468 to 1cd567e

@embray
Copy link
Contributor

embray commented Jun 1, 2018

Changed commit from 1cd567e to none

@embray
Copy link
Contributor

embray commented Jun 1, 2018

comment:9

Replying to @saraedum:

Great, thanks. Yes, I thought it's more welcoming if I make it sound like it's something that we'd like to have. I wouldn't mind accepting PRs on GitHub but I don't want to maintain the necessary infrastructure and if I had to choose, I'd prefer MRs on GitLab.

Btw, could you also disable the Wiki & Projects on our GitHub page? We might want to leave the issues tab active so people get to see the message that redirects them to trac?

Done. I think they'll still see the relevant message if they go to submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants