Fix bug in is_regular

[sagetrac-tdouvropoulos]

The function is_regular for elements of complex reflection groups has a bug.

For example, the following code gives:

sage: W=ReflectionGroup(["A",5])
sage: w=W.from_reduced_word([1,2,3,5])
sage: w.is_regular(4)
True

The element w above is (1234)(56), and is not regular. Its order isn't even a regular number.

CC: @tscrim @stumpc5

Component: combinatorics

Keywords: reflection groups, days93.51

Author: Theo Douvropoulos

Branch/Commit: e0a1db4

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/25478

[sagetrac-tdouvropoulos]

Commit: a13f839

[sagetrac-tdouvropoulos]

Reviewer: Travis Scrimshaw

[sagetrac-tdouvropoulos]

Branch: public/combinat/fix_is_regular

[sagetrac-tdouvropoulos]

Changed author from tdouvropoulos to Theo Douvropoulos

[sagetrac-tdouvropoulos]

New commits:

a13f839

Fixing is_regular for complex reflection groups.

[sagetrac-git]

Changed commit from a13f839 to 1677bfc

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

1677bfc

Added test documentation in is_regular

[sagetrac-git]

Changed commit from 1677bfc to e104f57

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

e104f57

Fixed examples.

[sagetrac-git]

Changed commit from e104f57 to 4f119e4

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

4f119e4

Improved code

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

b25ec8f

Some changes and simplifications to the code.

[sagetrac-git]

Changed commit from 4f119e4 to b25ec8f

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

c70c41c

Some changes and simplifications to the code.

[sagetrac-git]

Changed commit from b25ec8f to c70c41c

[tscrim]

comment:7

If my changes look good, then positive review.

[sagetrac-git]

Changed commit from c70c41c to ab41798

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

ab41798

Fixed bug in code

[sagetrac-tdouvropoulos]

comment:9

The base change to the Universal cyclotomic field needs to happen every time including the crystallographic groups. The eigenvectors of elements in crystallographic groups are not always defined over Q.

[stumpc5]

comment:10

oh yes...

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

cdf429d

Simplified code

[sagetrac-git]

Changed commit from ab41798 to cdf429d

[tscrim]

Changed keywords from reflection groups, days 93.51 to reflection groups, days93.51

[sagetrac-git]

Changed commit from cdf429d to 426248c

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

596b2f7	Implement fake degree polynomials from Chevie.
dd7c992	Improved code and description
16f6c87	Reviewer changes for fake_degrees.
531cc09	Adding Malle's Coxeter numbers
627c973	Small modifications
b49d8b7	Reviewer changes.
4ac2eda	Merge branch 'public/combinat/Malle-Coxeter-number' into public/combinat/fake_degree_polys
10b07ba	Merge branch 'public/combinat/fix_is_regular' of trac.sagemath.org:sage into public/combinat/fix_is_regular
426248c	Some last little changes.

[sagetrac-git]

Changed commit from 426248c to 582e7b0

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

582e7b0

Some last little changes.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

e0a1db4

Fixed minor typo

[sagetrac-git]

Changed commit from 582e7b0 to e0a1db4

[vbraun]

Changed branch from public/combinat/fix_is_regular to e0a1db4