Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyflakes cleanup in plot/plot.py #25521

Closed
fchapoton opened this issue Jun 6, 2018 · 19 comments
Closed

pyflakes cleanup in plot/plot.py #25521

fchapoton opened this issue Jun 6, 2018 · 19 comments
Labels
c: graphics p: major / 3 t: enhancement
Milestone
sage-8.3

Comments

@fchapoton
Copy link
Contributor

on the way, removing a whole set of old alias imports.

Component: graphics

Author: Frédéric Chapoton

Branch/Commit: 12305a6

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/25521
@fchapoton fchapoton added this to the sage-8.3 milestone Jun 6, 2018
@fchapoton
Copy link
Contributor Author

New commits:

4554a54pyflakes cleanup of plot/plot.py

@fchapoton
Copy link
Contributor Author

Commit: 4554a54

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/25521

@fchapoton

This comment has been minimized.

Sign in to view
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 7, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

6aad51bfix some imports

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 7, 2018

Changed commit from 4554a54 to 6aad51b

@tscrim
Copy link
Collaborator

tscrim commented Jun 7, 2018

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jun 7, 2018

comment:3

LGTM.

@fchapoton
Copy link
Contributor Author

comment:4

thanks, Travis ; But maybe we should wait for a green patchbot ?

@tscrim
Copy link
Collaborator

tscrim commented Jun 7, 2018

comment:5

Indeed, the patchbot did come back with issues.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 7, 2018

Changed commit from 6aad51b to a0be77f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 7, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

a0be77ffixing a few imports

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 7, 2018

Changed commit from a0be77f to 2becab0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 7, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

2becab0fix more imports

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 7, 2018

Changed commit from 2becab0 to 12305a6

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 7, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

12305a6more details / pyflakes

@fchapoton
Copy link
Contributor Author

comment:9

ok. not perfect, but good enough maybe ?

@tscrim
Copy link
Collaborator

tscrim commented Jun 8, 2018

comment:11

We can always do more on later tickets.

@vbraun
Copy link
Member

vbraun commented Jun 11, 2018

Changed branch from u/chapoton/25521 to 12305a6

@vbraun vbraun closed this as completed in 02287a2 Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: graphics p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.3
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton