Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cysignals include #25531

Closed
jdemeyer opened this issue Jun 7, 2018 · 6 comments
Closed

Fix cysignals include #25531

jdemeyer opened this issue Jun 7, 2018 · 6 comments
Labels
c: cython p: major / 3 t: bug
Milestone
sage-8.3

Comments

@jdemeyer
Copy link

jdemeyer commented Jun 7, 2018

This (deprecated) include is causing problems with non-standard Sage installations. Since cython() adds the cysignals include path, this should fix it.

CC: @timokau

Component: cython

Author: Jeroen Demeyer

Branch/Commit: 28778bd

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/25531
@jdemeyer jdemeyer added this to the sage-8.3 milestone Jun 7, 2018
@jdemeyer
Copy link
Author

jdemeyer commented Jun 7, 2018

Branch: u/jdemeyer/ticket/25531

@jdemeyer
Copy link
Author

jdemeyer commented Jun 7, 2018

New commits:

28778bdFix cysignals include

@jdemeyer
Copy link
Author

jdemeyer commented Jun 7, 2018

Commit: 28778bd

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:3

ok

@vbraun
Copy link
Member

vbraun commented Jun 9, 2018

Changed branch from u/jdemeyer/ticket/25531 to 28778bd

@vbraun vbraun closed this as completed in fdf3f40 Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: cython p: major / 3 t: bug
Projects
None yet
Milestone
sage-8.3
Development

No branches or pull requests
3 participants
@vbraun @jdemeyer @fchapoton