Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: adding hash functions for Laurent polys, Toric var. and overconvergent forms #25591

Closed
fchapoton opened this issue Jun 16, 2018 · 10 comments
Closed

py3: adding hash functions for Laurent polys, Toric var. and overconvergent forms #25591

fchapoton opened this issue Jun 16, 2018 · 10 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-8.3

Comments

@fchapoton
Copy link
Contributor

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 3760a83

Reviewer: Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/25591
@fchapoton fchapoton added this to the sage-8.3 milestone Jun 16, 2018
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/25591

@fchapoton
Copy link
Contributor Author

Commit: 8ffe055

@fchapoton
Copy link
Contributor Author

New commits:

8ffe055adding 3 hash functions : LaurentPoly, Overconvergent forms, Toric

@videlec
Copy link
Contributor

videlec commented Jun 17, 2018

comment:2

For Laurent polynomial ring it is not a good idea to give it the same hash as the underlying multi-polynomial ring. You would better xor it with a random number

    return hash(self._R) ^ 12059065606945654693

@videlec
Copy link
Contributor

videlec commented Jun 17, 2018

Reviewer: Vincent Delecroix

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 17, 2018

Changed commit from 8ffe055 to 3760a83

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 17, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

3760a83fixing hash of LaurentPolynomial rings

@fchapoton
Copy link
Contributor Author

comment:5

Merci. C'est fait.

@videlec
Copy link
Contributor

videlec commented Jun 17, 2018

comment:6

you use 8.3.beta5 before it is announced :-)

@vbraun
Copy link
Member

vbraun commented Jun 19, 2018

Changed branch from u/chapoton/25591 to 3760a83

@vbraun vbraun closed this as completed in 92b4ce5 Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.3
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @videlec