New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graph.is_gallai_tree() method has an error in the code #25613
Labels
Milestone
Comments
This comment has been minimized.
This comment has been minimized.
Commit: |
Branch: public/25613 |
New commits:
|
Author: Frédéric Chapoton |
comment:4
LGTM. |
Reviewer: Travis Scrimshaw |
Changed branch from public/25613 to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The Graph.is_gallai_tree() method checks for whether a block's vertices induce a cycle tests if the number of edges is one more than the number of vertices. These should be the same.
The third-to-last-line currently has the test: gg.size() == len(c)+1
It should have the test: gg.size() == len(c)
A graph which is a 5-cycle with an appended edge to an external vertex is a gallai tree. But the existing method returns False. Call this graph "gg":
should return: True.
CC: @dcoudert
Component: graph theory
Author: Frédéric Chapoton
Branch/Commit:
f8a9c73
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/25613
The text was updated successfully, but these errors were encountered: