Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3: various fixes about range, map, filter #25687

Closed
fchapoton opened this issue Jun 28, 2018 · 11 comments
Closed

py3: various fixes about range, map, filter #25687

fchapoton opened this issue Jun 28, 2018 · 11 comments

Comments

@fchapoton
Copy link
Contributor

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 6cc68f2

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/25687

@fchapoton fchapoton added this to the sage-8.3 milestone Jun 28, 2018
@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/25687

@fchapoton
Copy link
Contributor Author

Commit: f3db12d

@fchapoton
Copy link
Contributor Author

New commits:

f3db12dpy3: various fixes, about range, map, filter

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 28, 2018

Changed commit from f3db12d to 6cc68f2

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 28, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

6cc68f2one fix

@tscrim
Copy link
Collaborator

tscrim commented Jun 28, 2018

comment:3

There are a bunch of "failed to compute analytic rank" on the patchbot report. Are those ignorable?

@fchapoton
Copy link
Contributor Author

comment:4

no, they should be taken care of. Cause by the change in src/sage/modular/btquotients/btquotient.py probably. This is a very touchy file... Not the first time that I had to withdraw my changes there.

@fchapoton
Copy link
Contributor Author

comment:5

or maybe not.. I am not able to reproduce them. And I do not see how this could come from my changes, which I have double-checked, and are all innocuous enough.

So they can probably be ignored. I will try to run my own patchbots on that.

@tscrim
Copy link
Collaborator

tscrim commented Jun 28, 2018

comment:6

I remember seeing them on other tickets and could be ignored there. I have no idea what causes them; they seem to be more transient failures (I am also unable to reproduce them). I thought I would check just to be sure.

@tscrim
Copy link
Collaborator

tscrim commented Jun 28, 2018

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Jun 30, 2018

Changed branch from u/chapoton/25687 to 6cc68f2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants