Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: fix dynamic_class #25693

Closed
embray opened this issue Jun 28, 2018 · 3 comments
Closed

py3: fix dynamic_class #25693

embray opened this issue Jun 28, 2018 · 3 comments
Labels
c: python3 p: major / 3 t: bug
Milestone
sage-8.3

Comments

@embray
Copy link
Contributor

embray commented Jun 28, 2018

dynamic_class is very broken on Python 3, at least in the tests. Fortunately the fix is (apparently) simple. See the commit log for more details.

CC: @nthiery

Component: python3

Author: Erik Bray

Branch/Commit: 43747a1

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/25693
@embray embray added this to the sage-8.3 milestone Jun 28, 2018
@fchapoton
Copy link
Contributor

comment:2

ok

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@vbraun
Copy link
Member

vbraun commented Jun 30, 2018

Changed branch from u/embray/python3/sage-structure-dynamic_class to 43747a1

@vbraun vbraun closed this as completed Jun 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: bug
Projects
None yet
Milestone
sage-8.3
Development

No branches or pull requests
3 participants
@embray @vbraun @fchapoton