Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3: fix DeprecationWarning of imp in sage.misc.inline_fortran #25703

Closed
embray opened this issue Jun 29, 2018 · 8 comments
Closed

py3: fix DeprecationWarning of imp in sage.misc.inline_fortran #25703

embray opened this issue Jun 29, 2018 · 8 comments

Comments

@embray
Copy link
Contributor

embray commented Jun 29, 2018

This adds a new _import_module_from_path that encapsulates the existing code from this module for searching a directory for a module and importing it, but implements in both Python 2 and Python 3(.4+) compatible ways.

I think in theory this utility could be made public, and moved to a more general module, but I couldn't decide where so I just left it here for now. Maybe if another use case is found for it...

Component: python3

Author: Erik Bray

Branch/Commit: 8261915

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/25703

@embray embray added this to the sage-8.3 milestone Jun 29, 2018
@embray
Copy link
Contributor Author

embray commented Jun 29, 2018

Commit: 8261915

@embray
Copy link
Contributor Author

embray commented Jun 29, 2018

New commits:

8261915py3: adds a _import_module_from_path helper function

@embray
Copy link
Contributor Author

embray commented Jun 29, 2018

@fchapoton
Copy link
Contributor

comment:3

is this a (better) duplicate of #25599 ?

@fchapoton
Copy link
Contributor

comment:4

ok

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@embray
Copy link
Contributor Author

embray commented Jul 18, 2018

comment:5

I believe this issue can reasonably be addressed for Sage 8.4.

@embray embray modified the milestones: sage-8.3, sage-8.4 Jul 18, 2018
@vbraun
Copy link
Member

vbraun commented Aug 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants