Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Posets: Add random maximal (anti)chain & linext #25716

Closed
jm58660 mannequin opened this issue Jun 30, 2018 · 10 comments
Closed

Posets: Add random maximal (anti)chain & linext #25716

jm58660 mannequin opened this issue Jun 30, 2018 · 10 comments
Labels
c: combinatorics p: major / 3 t: enhancement
Milestone
sage-8.4

Comments

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Jun 30, 2018

As asked in #25596, make (visible) functions to get a random maximal chain, antichain and linear extension of a poset.

CC: @tscrim

Component: combinatorics

Keywords: days94

Author: Jori Mäntysalo

Branch/Commit: 2cd6dc6

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/25716
@jm58660 jm58660 mannequin added this to the sage-8.3 milestone Jun 30, 2018
@jm58660 jm58660 mannequin added c: combinatorics labels Jun 30, 2018
@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Jun 30, 2018

Branch: u/jmantysalo/posets__add_random_maximal__anti_chain___linext

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Jun 30, 2018

New commits:

f7e066bAdd three *random() -functions.

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Jun 30, 2018

Commit: f7e066b

@jm58660 jm58660 mannequin added the s: needs review label Jun 30, 2018
@tscrim
Copy link
Collaborator

tscrim commented Jul 1, 2018

comment:3

LGTM modulo removing the randint import in random_maximal_antichain (unused; see pyflakes report).

@tscrim
Copy link
Collaborator

tscrim commented Jul 1, 2018

Changed keywords from none to days94

@tscrim
Copy link
Collaborator

tscrim commented Jul 1, 2018

Reviewer: Travis Scrimshaw

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 1, 2018

Changed commit from f7e066b to 2cd6dc6

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 1, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

2cd6dc6Remove unused import.

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Jul 1, 2018

comment:5

Replying to @tscrim:

LGTM modulo removing the randint import in random_maximal_antichain (unused; see pyflakes report).

Good catch. Removed.

@jm58660 jm58660 mannequin modified the milestones: sage-8.3, sage-8.4 Jul 12, 2018
@vbraun
Copy link
Member

vbraun commented Aug 5, 2018

Changed branch from u/jmantysalo/posets__add_random_maximal__anti_chain___linext to 2cd6dc6

@vbraun vbraun closed this as completed in 6eb7977 Aug 5, 2018
@jm58660 jm58660 mannequin mentioned this issue Aug 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.4
Development

No branches or pull requests
2 participants
@vbraun @tscrim